Some Direct Debugging fixes #4440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
NickGerleman
approved these changes
Mar 27, 2020
NickGerleman
pushed a commit
to NickGerleman/react-native-windows
that referenced
this pull request
Mar 30, 2020
* Fix direct debugging * formatting * Change files
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Apr 3, 2020
* Fix direct debugging * formatting * Change files
ghost
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Fix crash when calling measure on non-framework element (#4473) * Fix crash when calling measure on non-framework element * Change files * Fix new project build (#4469) * Set $(ReactNativeWindowsDir) before it is used * Change files * Update MSBuild ADO Tasks to use MSBuild x64 (#4462) * Removed x86 override for msbuild tasks in CI, publish * Switch from MSBuild to VSBuild * Added `<AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGeneratePrisForPortableLibrariesEnabled>` to C# app projects to fix build issues with msbuild x64 * Added `/p:AppxGeneratePrisForPortableLibrariesEnabled=false` for testcli build task * Some Direct Debugging fixes (#4440) * Fix direct debugging * formatting * Change files * Add timeout to certificate generation on project init (#4430) * Add a timeout to catch hangs during cert generation * Change files * Update change files to use patch version bumping * publishing fix Co-authored-by: Vladimir Morozov <vmoroz@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when enabling direct debugging at run-time using the dev menu
This was caused by a bad hook up the UI buttons, where the break at next statement and direct debugging callback were both hooked up to the direct debugging button.
Direct debugging does not work with FastRefresh
Currently either webdebugging or livereload are the conditions to get the bundle from the metro server. We should include fastRefresh in that logic.
Before using direct debugging, the user has to disable remote debugging
Direct Debugging is fundamentally incompatible with remote debugging. Previously the user had to manually disable one before enabling the other. This PR toggles the other one for you.
Microsoft Reviewers: Open in CodeFlow