Move playground app to use Microsoft.ReactNative #4534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
reviewed
Apr 8, 2020
NickGerleman
reviewed
Apr 9, 2020
NickGerleman
reviewed
Apr 9, 2020
NickGerleman
reviewed
Apr 9, 2020
NickGerleman
reviewed
Apr 9, 2020
NickGerleman
reviewed
Apr 9, 2020
ghost
added
the
Needs: Author Feedback
asklar
reviewed
Apr 9, 2020
asklar
reviewed
Apr 9, 2020
asklar
reviewed
Apr 9, 2020
asklar
reviewed
Apr 9, 2020
Member
|
(Can't add a comment to the pfx file so adding it here) |
asklar
previously requested changes
Apr 9, 2020
Member
asklar
left a comment
asklar
left a comment
There was a problem hiding this comment.
Please change the markup string to be a xaml file and ideally make the list of items in the combobox databound so we don't have to manually update it every time we implement a new type, we can just drop a new .js page
ghost
removed
the
Needs: Author Feedback
vmoroz
approved these changes
Apr 9, 2020
Contributor
Author
|
@NickGerleman, @asklar moved to proper XAML files, and removed a bunch of the junk created by the react-native init template that doesn't make sense for us. |
asklar
reviewed
Apr 9, 2020
asklar
reviewed
Apr 9, 2020
| <ComboBoxItem Content="Samples\text" /> | ||
| <ComboBoxItem Content="Samples\textinput" /> | ||
| <ComboBoxItem Content="Samples\ticTacToe" /> | ||
| <ComboBoxItem Content="Samples\view" /> |
Member
There was a problem hiding this comment.
can these be dynamicaly discovered?
Contributor
Author
There was a problem hiding this comment.
I'm going to punt on this for this PR. The old playground had these hard coded too...
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
NickGerleman
approved these changes
Apr 9, 2020
acoates-ms
dismissed
asklar’s stale review
Punting on additional cleanup of playground beyond what was there before moving off ReactUWP.
asklar
approved these changes
Apr 9, 2020
Member
asklar
left a comment
asklar
left a comment
There was a problem hiding this comment.
I'd love to see the combobox adds be done in code as it was before (while keeping the rest of the xaml in markup), so that we can easily add dynamic discovery.
asklar
pushed a commit
to asklar/react-native-windows
that referenced
this pull request
Apr 10, 2020
* Move playground app to use Microsoft.ReactNative * formatting * Bunch of code review feedback * Change files * formatting * Delete unneeded gitignore * Minor removal of diff * Minor changes to try to avoid having to update cert all the time * Fix bundle command * No need to build rntester seperately, the release build of playground will do it from msbuild * Remove test property
ghost
pushed a commit
that referenced
this pull request
Apr 22, 2020
* Publish fix * Creating new Microsoft.ReactNative.sln (#4535) * Created new Microsoft.ReactNative.sln * Update PR to build vnext/Microsoft.ReactNative.sln * Add params to disable ReactUWP nuget pack during PR * applying package updates ***NO_CI*** * Move playground app to use Microsoft.ReactNative (#4534) * Move playground app to use Microsoft.ReactNative * formatting * Bunch of code review feedback * Change files * formatting * Delete unneeded gitignore * Minor removal of diff * Minor changes to try to avoid having to update cert all the time * Fix bundle command * No need to build rntester seperately, the release build of playground will do it from msbuild * Remove test property * Bump beachball from 1.28.0 to 1.28.1 (#4539) * applying package updates ***NO_CI*** * applying package updates ***NO_CI*** * Enabling managed unit tests in CI loop (#4532) * Disable .net native for managed unit tests * Change files * Enable managed unit tests in ci loop * re-merge unit test tasks, can't run arm anyway * Remove prefer 32bit from 64bit flavors * Update mstest dependencies * Managed tests are separate again * Add comment * Add test adapter path * x86 debug again * Update test adapter folder * Try again * remove frameworkuap10 * Switch to appxrecipie * Try to switch to installed version of vstest * Remove installer task * applying package updates ***NO_CI*** * Remove 'Delete Android SDK' from E2ETest (#4554) * Enable WebSocketModule unit tests (#4538) * Prototype mockable MessageQueueThread and JSExecutor * Declare MockJSExecutor::CallFunctionFunctor * Add missing using std::unique_ptr * Use WebSocketModule::MethodId * clang format * Make WebSocketModule methods override instead of virtual. * Allow WebSocketModule to use custom resource factory * Rename *Impl to *Mock * Move Instance mocks into separate source files * Move Instance mocks into separate source files * Change files * clang format * Define WebSocketModule::SetResourceFactory * applying package updates ***NO_CI*** * Improve inner loop and error reporting (local CLI) (#4536) -Surface msbuild errors (shows as undefined right now) -downloading nuget with Invoke-WebRequest will usually take a long time because of the PS progress bar (which sadly gets updated for every byte), so I'm disabling the progress bar (it only takes a second to download when the progress bar is turned off) retry once if nuget failed since if you cancel at just the right time, you could end up with a truncated nuget.exe and are wedged unless you know which file to delete. Learned that the hard way. -factor out calling onto powershell functions -we were not exposing whether the function failed or not * applying package updates ***NO_CI*** * Don't set readyState on connection error (#4562) * Don't set readyState on connection error * Change files * applying package updates ***NO_CI*** * Bump @babel/core from 7.8.4 to 7.9.0 (#4565) * Simplified C++ macros and improved their comments (#4568) * Simplified C++ macros and improved their comments * Change files * applying package updates ***NO_CI*** * Handle syntax errors in RedBox * Change files * format * clean up Co-authored-by: Andrew Coates (REDMOND) <acoates@microsoft.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Julio César Rocha <JunielKatarn@users.noreply.github.com> Co-authored-by: Vladimir Morozov <vmoroz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This does not move playground.win32 over
Microsoft Reviewers: Open in CodeFlow