Fix issue with yoga in X64 Release builds #4628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
Apr 17, 2020
| <ClCompile Include="$(YogaDir)\yoga\YGStyle.cpp" DisableSpecificWarnings="4244;%(DisableSpecificWarnings)" /> | ||
| <ClCompile Include="$(YogaDir)\yoga\YGValue.cpp" /> | ||
| <ClCompile Include="$(YogaDir)\yoga\Yoga.cpp" DisableSpecificWarnings="4244;%(DisableSpecificWarnings)" /> | ||
| <ClCompile Condition="'$(Platform)' == 'x64'" Include="$(YogaDir)\yoga\Yoga.cpp" DisableSpecificWarnings="4244;%(DisableSpecificWarnings)" FloatingPointModel="Strict" /> |
Contributor
There was a problem hiding this comment.
Could you add a comment with a link to the issue here?
Member
There was a problem hiding this comment.
Note that I'm only able to see a difference in we build x64 AND Release (x64 Debug looks ok)
Member
|
Could you file an issue to undo this workaround when we get a fix from MSVC? |
asklar
approved these changes
Apr 17, 2020
| <ClCompile Include="$(YogaDir)\yoga\YGStyle.cpp" DisableSpecificWarnings="4244;%(DisableSpecificWarnings)" /> | ||
| <ClCompile Include="$(YogaDir)\yoga\YGValue.cpp" /> | ||
| <ClCompile Include="$(YogaDir)\yoga\Yoga.cpp" DisableSpecificWarnings="4244;%(DisableSpecificWarnings)" /> | ||
| <ClCompile Condition="'$(Platform)' == 'x64'" Include="$(YogaDir)\yoga\Yoga.cpp" DisableSpecificWarnings="4244;%(DisableSpecificWarnings)" FloatingPointModel="Strict" /> |
Member
There was a problem hiding this comment.
Note that I'm only able to see a difference in we build x64 AND Release (x64 Debug looks ok)
Contributor
Author
|
Yes, but we may as well have debug match the strict mode to try to minimize the differences between release and debug. |
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
asklar
pushed a commit
to asklar/react-native-windows
that referenced
this pull request
Apr 19, 2020
* Fix issue with yoga layout in x64 release * Change files * Update E2E masters * code review feedback
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4122
There seems to be an issue with the v142 compiler bits which causes the code generated around CompactValue.isUndefined to not always return the correct value.
Using fp:Strict within yoga.cpp works around the issue.
An alternative would be to fork CompactValue, and add pragma's to enable strict just around that. -- Or wait for a compiler fix. We should look at disabling this change on compiler updates to see if the compiler issue has been fixed.
Microsoft Reviewers: Open in CodeFlow