Skip to content

E2ETest failure: Padding doesn't work for Views on VS 2019, v142 tools, Release x64 #4122

@jonthysell

Description

@jonthysell

As part of PR #4101, the measureLayout E2E test is failing on the windows-2019 VM because the View's padding is not being applied.

I've confirmed that it repros on my 19H1+ machine, when building in VS 2019 and the v142 toolset.

We are patching Yoga.cpp in vnext\DeforkingPatches\ReactCommon\yoga\yoga\Yoga.cpp to add an extra measure call, apparently for the benefit of react-native-win32, but it has the side effect of messing up react-native-windows.

Removing that patch fixes the issue for react-native-windows, but may cause other unintended side-effects in react-native-windows, and of course probably messes up react-native-win32.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions