react-native-windows-init should support npm tags for --version parameter #4647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 41 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
asklar
approved these changes
Apr 21, 2020
| return; | ||
| } | ||
| candidates = candidates.sort(semver.rcompare); | ||
| if (candidates && candidates.length > 0) { |
Member
There was a problem hiding this comment.
can there be more than one match (e.g. wildcards)? if so, print them and error out
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had code to try to support npm tags for the --version parameter on
react-native-windows-init, and are even using it in our CI loops to installed the test version. But there appears to be a difference in behavior between npmjs.org and verdaccio which causes it to work when running against verdaccio but it still doesn't work against npmjs.org.This should enable instructions to run against latest master to be:
Microsoft Reviewers: Open in CodeFlow