Skip to content

react-native-windows-init should support npm tags for --version parameter #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Apr 21, 2020
Merged

react-native-windows-init should support npm tags for --version parameter #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98f8b75
Fix react-native-windows-init to work with tags (@master)
acoates-ms Apr 20, 2020
89362b2
Change files
acoates-ms Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-init-2020-04-20-13-55-48-tagininit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "Fix react-native-windows-init to work with tags (@master)",
"packageName": "react-native-windows-init",
"email": "acoates@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-04-20T20:55:48.747Z"
}
50 changes: 33 additions & 17 deletions packages/react-native-windows-init/src/Cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import * as yargs from 'yargs';
import * as fs from 'fs';
import * as semver from 'semver';
import {execSync} from 'child_process';
import {exec, execSync} from 'child_process';
import * as validUrl from 'valid-url';
import * as prompts from 'prompts';
import * as findUp from 'find-up';
Expand Down Expand Up @@ -171,22 +171,38 @@ function getLatestMatchingVersion(
},
);
} else {
// Assume that versionSemVer is actually a tag
npm.packages.release(
pkg,
versionSemVer,
(err: any, details: {version: string}[]) => {
if (err) {
reject(err);
} else if (details && details.length > 0) {
resolve(details[0].version);
return;
}
reject(
new Error(`No matching version of ${pkg}@${versionSemVer} found`),
);
},
);
try {
exec(
`npm info ${pkg}@${versionSemVer} version --json`,
(err, stdout, _stderr) => {
try {
if (!err) {
let candidates = JSON.parse(stdout);
if (typeof candidates === 'string') {
resolve(candidates);
return;
}
candidates = candidates.sort(semver.rcompare);
if (candidates && candidates.length > 0) {
Copy link
Member

@asklar asklar Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can there be more than one match (e.g. wildcards)? if so, print them and error out

resolve(candidates[0]);
return;
}
}
reject(
new Error(
`No matching version of ${pkg}@${versionSemVer} found`,
),
);
} catch (e) {
reject(e);
}
},
);
} catch (err) {
reject(
new Error(`No matching version of ${pkg}@${versionSemVer} found`),
);
}
}
});
}
Expand Down