Skip to content

Added C++ ReactContext for Module Initialize method #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Apr 26, 2020
Merged

Added C++ ReactContext for Module Initialize method #4721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2468dd6
Added C++ ReactContext for Module Initialize method
vmoroz Apr 26, 2020
7232f81
Change files
vmoroz Apr 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-2020-04-26-08-36-51-MS_Cxx_ReactContext.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "Added C++ ReactContext for Module Initialize method",
"packageName": "react-native-windows",
"email": "vmorozov@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-04-26T15:36:51.338Z"
}
2 changes: 1 addition & 1 deletion packages/microsoft-reactnative-sampleapps/windows/SampleLibraryCPP/SampleModuleCPP.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ struct SampleModuleCppImpl {
#pragma region Initialization

REACT_INIT(Initialize)
void Initialize(IReactContext const & /*reactContext*/) noexcept {
void Initialize(ReactContext const & /*reactContext*/) noexcept {
m_timer = winrt::Windows::System::Threading::ThreadPoolTimer::CreatePeriodicTimer(
[this](const winrt::Windows::System::Threading::ThreadPoolTimer) noexcept {
TimedEvent(++m_timerCount);
Expand Down
4 changes: 2 additions & 2 deletions vnext/Microsoft.ReactNative.Cxx.UnitTests/NativeModuleTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ namespace ReactNativeTests {
REACT_MODULE(SimpleNativeModule)
struct SimpleNativeModule {
REACT_INIT(Initialize)
void Initialize(React::IReactContext const &context) noexcept {
void Initialize(React::ReactContext const &context) noexcept {
IsInitialized = true;
TestCheck(context != nullptr);
TestCheck(context);

// Event and Function fields are initialized before REACT_INIT method call.
TestCheck(this->OnIntEvent != nullptr);
Expand Down
Loading