Added C++ ReactContext for Module Initialize method #4721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we work on the C++ TurboModules, we want this design to be applicable for the generic C++ code and not just C++/WinRT. During the latest TurboModule design review with @acoates-ms he has noticed that the only required use of the C++/WinRT interfaces in the user-written TurboModule code is the new
Initializemethod with theREACT_INITattribute. In all other places we already use abstractions such asReactConstantProvider,ReactPromise,ReactError, etc.In this change we add the new
ReactContextinto theMicrosoft.ReactNative.Cxxshared code:IReactContextJSValueArgWriterdelegate with help of the newMakeJSValueArgWritermethod.Initializemethod is similar to the use of theReactConstantProviderfor the constant provider methods.Note that it is a breaking change for any code that already started to use the
REACT_INITattribute for Native Modules. After this PR is merged, all code must be changed to use theReactContextstruct instead of theIReactContextinterface. TheREACT_INITis a new attribute in RNW 0.62 and the change must have low impact on existing code.Microsoft Reviewers: Open in CodeFlow