Added C# ReactContext for Module Initialize method #4722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@vmoroz do you want this pulled into 62? |
NickGerleman
approved these changes
Apr 27, 2020
Member
Author
|
@NickGerleman yes, ideally it should be part of 0.62 In reply to: 619710567 [](ancestors = 619710567) |
vmoroz
added
the
AutoMerge
|
Hello @vmoroz! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
NickGerleman
pushed a commit
to NickGerleman/react-native-windows
that referenced
this pull request
May 2, 2020
* Added C# ReactContext for Module Initialize method * Change files * Fixed sample project compilation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to C# Native Module API matching to C++ changes previously done in PR #4721.
This PR replaces use of
IReactContextwith the newReactContextstruct.Previously most of the
ReactContextmethods were implemented as extension methods, In this PR they are replaced asReactContextinstance methods.Other related changes:
IReactContextfrom theReactContextasContextAbiproperty.IJSValueWriterfrom theReactConstantProviderasWriterproperty.The change requires changing signature of all existing ReactInititialzer methods to use
ReactContextinstead ofIReactContext.Microsoft Reviewers: Open in CodeFlow