Move playground-win32 to Microsoft.ReactNative #4895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
approved these changes
May 13, 2020
vmoroz
reviewed
May 13, 2020
dannyvv
approved these changes
May 13, 2020
| auto cmbEngines = GetDlgItem(hwnd, IDC_JSENGINE); | ||
| int itemIndex = (int)SendMessageW(cmbEngines, (UINT)CB_GETCURSEL, (WPARAM)0, (LPARAM)0); | ||
| self->m_jsEngine = static_cast<react::uwp::JSIEngine>(itemIndex); | ||
| // auto cmbEngines = GetDlgItem(hwnd, IDC_JSENGINE); |
Member
There was a problem hiding this comment.
intentional? Other places you commented on why it was commented out.
| SendMessageW(cmbEngines, (UINT)CB_ADDSTRING, (WPARAM)0, (LPARAM)TEXT("Hermes")); | ||
| SendMessageW(cmbEngines, (UINT)CB_ADDSTRING, (WPARAM)0, (LPARAM)TEXT("V8")); | ||
| SendMessageW(cmbEngines, CB_SETCURSEL, (WPARAM) static_cast<int32_t>(self->m_jsEngine), (LPARAM)0); | ||
| // SendMessageW(cmbEngines, CB_SETCURSEL, (WPARAM) static_cast<int32_t>(self->m_jsEngine), (LPARAM)0); |
Member
There was a problem hiding this comment.
Intentional? Other places you commented on why it was commented out.
Contributor
Author
There was a problem hiding this comment.
Mostly because I expect this functionality to come back soon as we add support for switching engines to the public API.
vmoroz
reviewed
May 13, 2020
Contributor
|
What was the plan re: RNTester AsyncStorage dependency, or does that just work right now? |
asklar
reviewed
May 14, 2020
| break; | ||
| case winrt::Microsoft::ReactNative::RedBoxErrorType::Native: | ||
| OutputDebugStringA("Native Error: "); | ||
| break; |
Member
There was a problem hiding this comment.
consider using the functionality provided by cdebug.h
asklar
reviewed
May 14, 2020
packages/playground/windows/playground-win32/Playground-win32.vcxproj
Outdated
Show resolved
Hide resolved
asklar
reviewed
May 14, 2020
packages/playground/windows/playground-win32/Playground-win32.vcxproj
Outdated
Show resolved
Hide resolved
asklar
reviewed
May 14, 2020
packages/playground/windows/playground-win32/Playground-win32.vcxproj
Outdated
Show resolved
Hide resolved
asklar
reviewed
May 15, 2020
asklar
reviewed
May 15, 2020
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the playground-win32 project from ReactUwp to Microsoft.ReactNative.
#4919 is required to actually be able to run playground-win32, as it fixes a crash in AttachBackHandlers which hits Xaml Islands on boot.
Fixes #3854
Microsoft Reviewers: Open in CodeFlow