ReactApplication should not impose a ReactRootView #4949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
reviewed
May 19, 2020
vmoroz
reviewed
May 19, 2020
vmoroz
reviewed
May 19, 2020
vmoroz
reviewed
May 19, 2020
asklar
changed the title
This was
linked to
issues
May 23, 2020
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/packages.config
Outdated
Show resolved
Hide resolved
vmoroz
reviewed
May 26, 2020
packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/SampleAppCpp.vcxproj
Outdated
Show resolved
Hide resolved
vmoroz
reviewed
May 26, 2020
packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/SampleAppCpp.vcxproj
Outdated
Show resolved
Hide resolved
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
Member
vmoroz
reviewed
May 26, 2020
vnext/local-cli/generator-windows/templates/cpp/src/MainPage.cpp
Outdated
Show resolved
Hide resolved
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
vmoroz
reviewed
May 26, 2020
asklar
changed the title
| } | ||
|
|
||
| function printFailedTests(ft) { | ||
| console.log('Failed test cases: '); |
Contributor
There was a problem hiding this comment.
Consider console.error and using Chalk to set a color.
NickGerleman
added
the
Breaking Change
Contributor
|
Marking as a breaking change since the template changes, and it seems like public APIs do as well (didn't look super closely tbh). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4925 and allows mixing RN content with non-RN in a markup-first way, fixes #4940
Fixes the exception I left in for #4619 now that the floating point bug is fixed.
Microsoft Reviewers: Open in CodeFlow