Integrate 4/22 Nightly Build #5690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And lint:fix
…ndows into integrate-4-22
ghost
added
acoates-ms
approved these changes
Aug 11, 2020
NickGerleman
added
the
AutoMerge
|
Hello @NickGerleman! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 1 hour 24 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 6, 2021
…tInput selection Summary: This diff cherry-picks the following commits from react-native-windows: * **4af6037c** - Integrate 4/22 Nightly Build (microsoft#5690) * Only kept native changes to TextInputViewManager.cpp from this commit. * **b8c063d1** - Fix Errant "Nested elements in TextInput are currently unsupported on… * Needed to eliminate spurious yellow box cherry-picked in **4af6037c** * **c9f64057** - [FIX] Cursor resetting in TextInput (microsoft#7056) * Actual fix for TextBox selection reset Test Plan: 1. Cloned to FBS 2. Compile Archon 3. Confirm TextInput cursor fixed {F447085524} For reference, here was the old behavior: {F447112485} Reviewers: skyle, mylando Reviewed By: skyle Subscribers: eliwhite Differential Revision: https://phabricator.intern.facebook.com/D26781359 Tasks: T85939098 Tags: ddr_ml_flagged_advice Signature: 26781359:1614791211:f409bbfd5723d484e15ea5cb78ff7f1f69105a66
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4694
Fixes #4594
This Integration pushes us another two weeks ahead. The most interesting changes here are the removal of Checkbox from core and the introduction of a TextInput ViewManager commands for non-Android platforms that we needed to replicate. This meant bringing back a working copy of TextInputExample to validate, where we see some issues which were separately logged.
Note that this change doesn't try to sync TextInput changes for react-native-win32, since its internal implementation is independent of React Native core's (And was already using separate ViewManager commands).
Microsoft Reviewers: Open in CodeFlow