[FIX] Cursor resetting in TextInput #7056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
marlenecota
reviewed
Feb 6, 2021
NickGerleman
added
Backport to 0.64 Approved
and removed
Request Backport to 0.64
labels
marlenecota
approved these changes
Feb 11, 2021
rectified95
added a commit
to rectified95/react-native-windows
that referenced
this pull request
Feb 12, 2021
* Fix cursor resetting in TextInput. * Change files * Do no preserve selection, just cursor. Co-authored-by: Igor Klemenski <igklemen@microsoft.com>
rectified95
added a commit
that referenced
this pull request
Feb 22, 2021
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 6, 2021
…tInput selection Summary: This diff cherry-picks the following commits from react-native-windows: * **4af6037c** - Integrate 4/22 Nightly Build (microsoft#5690) * Only kept native changes to TextInputViewManager.cpp from this commit. * **b8c063d1** - Fix Errant "Nested elements in TextInput are currently unsupported on… * Needed to eliminate spurious yellow box cherry-picked in **4af6037c** * **c9f64057** - [FIX] Cursor resetting in TextInput (microsoft#7056) * Actual fix for TextBox selection reset Test Plan: 1. Cloned to FBS 2. Compile Archon 3. Confirm TextInput cursor fixed {F447085524} For reference, here was the old behavior: {F447112485} Reviewers: skyle, mylando Reviewed By: skyle Subscribers: eliwhite Differential Revision: https://phabricator.intern.facebook.com/D26781359 Tasks: T85939098 Tags: ddr_ml_flagged_advice Signature: 26781359:1614791211:f409bbfd5723d484e15ea5cb78ff7f1f69105a66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying the contents of a
TextInputprogrammatically, the cursor position gets moved to the front, which is the default behavior of XAML. Overriding it to enable dynamic re-write scenarios - eg. auto-capitalize, removing forbidden characters etc..Fixes #6786
Microsoft Reviewers: Open in CodeFlow