Touch event crash #6692
Merged
Touch event crash #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rectified95
approved these changes
Dec 7, 2020
Contributor
rectified95
left a comment
rectified95
left a comment
There was a problem hiding this comment.
Thanks for the fix - I missed this when implementing the hit test.
rectified95
pushed a commit
to rectified95/react-native-windows
that referenced
this pull request
Apr 1, 2021
This reverts commit 7d293b3.
rectified95
added a commit
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6682
the Tag property is available on FrameworkElement, so when the app has elements that are not FE like hyperlinks (which are UIElements but not FE), we crash
Microsoft Reviewers: Open in CodeFlow