Restore nested press events in Text, and prevent crash. #7507
Conversation
This reverts commit 7d293b3.
That bug is about animations on RS5, is that the right link? |
asklar
left a comment
asklar
left a comment
There was a problem hiding this comment.
I think the fix you want instead of reverting it all is to close the "if (try as framework element)" block right after assigning tag. That way if we didn't assign it, tag will still be null
ghost
added
Needs: Author Feedback
|
Fixed the bug/PR link in description, and replied to comment thread. |
rectified95
changed the title
| return fe.GetValue(xaml::FrameworkElement::TagProperty()).try_as<winrt::IPropertyValue>(); | ||
| } | ||
|
|
||
| inline int64_t GetTag(XamlView view) { |
There was a problem hiding this comment.
nit, another option is to return optional<int64_t> which might be nicer than using -1
There was a problem hiding this comment.
That's a nice idea. Would I then return early from a function calling this and getting an empty optional (or a -1 for that matter)?
There was a problem hiding this comment.
yes same idea, instead of checking for special -1 value you just check foo.has_value()
3 participants
This reverts commit 7d293b3.
#6692 fixed a crash we experienced in the e2e app when clicking on the test result hyperlink (a
TextBlockcreated outside of RNW, which didn't have a Tag, and our hit test crashed when trying to access the TagProperty which wasn't there.)However, this broke the entire hit testing algorithm for nested Text elements - the added check for whether an element was a
FrameworkElementbefore calling el.GetValue(TagProperty) skips the iteration overInlineelements of aSpanin aTextBlock, because they're not FE.Instead, using
ReadLocalValuesince it returnsUnsetValuein case a dependency property is not present on an element.Microsoft Reviewers: Open in CodeFlow