Skip to content

Conversation

@asklar
Copy link
Member

@asklar asklar commented Jan 29, 2021

Root control uses an RS4+ only API, causing crashes at startup on RS3 and below.

Followup fixes #5132

Microsoft Reviewers: Open in CodeFlow

@asklar asklar requested a review from a team as a code owner January 29, 2021 09:15
@ghost ghost added the Area: Animation label Jan 29, 2021
@asklar asklar added AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) and removed Area: Animation labels Jan 29, 2021
@ghost
Copy link

ghost commented Jan 29, 2021

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@dannyvv
Copy link
Member

dannyvv commented Jan 29, 2021

Code was introduced with: #4623 It seems it should not affect the back behavior too much on older windows versions...
@DrewHiggins as FYI

@asklar asklar removed the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jan 29, 2021
@ghost ghost merged commit 099dab0 into microsoft:master Jan 29, 2021
@asklar asklar deleted the rs3crash branch March 1, 2021 07:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default app crashes on Windows 10 1709 and 1803

2 participants