Skip to content

Fix startup crash on RS3 #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jan 29, 2021
Merged

Fix startup crash on RS3 #6980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4adee10
App crashes at startup on RS3 because of RS4+ API usage
asklar Jan 29, 2021
15b551d
Change files
asklar Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-2f9e933a-0ef8-4ee6-af39-dd343420ccab.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "App crashes at startup on RS3 because of RS4+ API usage",
"packageName": "react-native-windows",
"email": "asklar@microsoft.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion vnext/Microsoft.ReactNative/Views/ReactRootControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ void ReactRootControl::AttachBackHandlers(XamlView const &rootView) noexcept {
altLeft.Modifiers(winrt::Windows::System::VirtualKeyModifiers::Menu);

// Hide keyboard accelerator tooltips
rootElement.KeyboardAcceleratorPlacementMode(xaml::Input::KeyboardAcceleratorPlacementMode::Hidden);
if (react::uwp::IsRS4OrHigher()) {
rootElement.KeyboardAcceleratorPlacementMode(xaml::Input::KeyboardAcceleratorPlacementMode::Hidden);
}
}

void ReactRootControl::RemoveBackHandlers() noexcept {
Expand Down