.Net: Change Sqlite connector to accept connection string instead of DbConnection#10972
Merged
roji merged 2 commits intomicrosoft:feature-vector-data-preb2from Mar 14, 2025
Merged
.Net: Change Sqlite connector to accept connection string instead of DbConnection#10972roji merged 2 commits intomicrosoft:feature-vector-data-preb2from
roji merged 2 commits intomicrosoft:feature-vector-data-preb2from
Conversation
adamsitnik
approved these changes
Mar 14, 2025
dmytrostruk
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmit of #10550, which was closed when its target branch (
feature-vector-data-preb1) was deleted.Data Source=:memory:cannot be used in most cases, since the databases only lives while the connection is open, and disappears immediately when closed. This isn't perfect, but supporting in-memory would mean no concurrent usage.[Obsolete(error: true)], to have an informative error message for the user.Closes #10454
/cc @westey-m @dmytrostruk @adamsitnik