Skip to content

Avoid creating empty deployment directories on .NET Core when no deployment items are used #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 3 commits into from
Apr 24, 2026
Merged

Avoid creating empty deployment directories on .NET Core when no deployment items are used #7801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41d7049
Initial plan
Copilot Apr 24, 2026
18cd823
Avoid creating deployment item folders when not used on .NET Core
Copilot Apr 24, 2026
2768502
Move firstTestSource assignment after hasDeploymentItems check on .NE…
Copilot Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Adapter/MSTestAdapter.PlatformServices/Services/TestDeployment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ public bool Deploy(IEnumerable<TestCase> testCases, IRunContext? runContext, IFr
return false;
}

#if NETFRAMEWORK
string? firstTestSource = testCases.FirstOrDefault()?.Source;
RunDirectories = _deploymentUtility.CreateDeploymentDirectories(runContext, firstTestSource);

Expand All @@ -136,6 +137,16 @@ public bool Deploy(IEnumerable<TestCase> testCases, IRunContext? runContext, IFr
{
return false;
}
#else
// On .NET Core, avoid creating empty deployment folders when no deployment items are used.
if (!hasDeploymentItems)
{
return false;
}

string? firstTestSource = testCases.FirstOrDefault()?.Source;
RunDirectories = _deploymentUtility.CreateDeploymentDirectories(runContext, firstTestSource);
#endif

// Object model currently does not have support for SuspendCodeCoverage. We can remove this once support is added
#if NETFRAMEWORK
Expand Down
12 changes: 10 additions & 2 deletions test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Services/TestDeploymentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,12 @@ public void DeployShouldReturnFalseWhenDeploymentEnabledSetToFalseAndHasNoDeploy
// Deployment should not happen
testDeployment.Deploy(new List<TestCase> { testCase }, null, null!).Should().BeFalse();

// Deployment directories should get created
// Deployment directories should get created on .NET Framework for compat, but not on .NET Core
#if NETFRAMEWORK
testDeployment.GetDeploymentDirectory().Should().NotBeNull();
#else
testDeployment.GetDeploymentDirectory().Should().BeNull();
#endif
}

public void DeployShouldReturnFalseWhenDeploymentEnabledSetToTrueButHasNoDeploymentItems()
Expand All @@ -242,8 +246,12 @@ public void DeployShouldReturnFalseWhenDeploymentEnabledSetToTrueButHasNoDeploym
// Deployment should not happen
testDeployment.Deploy(new List<TestCase> { testCase }, null, null!).Should().BeFalse();

// Deployment directories should get created
// Deployment directories should get created on .NET Framework for compat, but not on .NET Core
#if NETFRAMEWORK
testDeployment.GetDeploymentDirectory().Should().NotBeNull();
#else
testDeployment.GetDeploymentDirectory().Should().BeNull();
#endif
}

// TODO: This test has to have mocks. It actually deploys stuff and we cannot assume that all the dependencies get copied over to bin\debug.
Expand Down