Don't set folding range collapsed text if client doesn't want it #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the folding range implementation to respect client capabilities regarding collapsed text. The language server now only sets the CollapsedText field on folding ranges when the client explicitly declares support for this feature via the FoldingRange.FoldingRange.CollapsedText capability.
Key Changes
- Added
supportsCollapsedTexthelper function to check client capabilities - Modified
createFoldingRangeto conditionally setCollapsedTextbased on client support - Propagated
context.Contextthrough all folding range creation functions to enable capability checking - Added
defaultFoldingRangeCapabilitiesconfiguration for tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/ls/folding.go | Added context parameter to all folding functions; implemented conditional collapsed text setting based on client capabilities |
| internal/fourslash/fourslash.go | Defined default folding range capabilities for testing (including collapsed text support) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, VS Code does not request this, nor do we even test it.