Skip to content

Don't set folding range collapsed text if client doesn't want it #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebailey wants to merge 2 commits into
base: main
Choose a base branch
from
+90 −66
Open

Don't set folding range collapsed text if client doesn't want it #2348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b26209
Don't set folding range collapsed text if client doesn't want it
jakebailey Dec 11, 2025
dfe11d9
oops
jakebailey Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions internal/fourslash/fourslash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,20 @@ var (
defaultDocumentSymbolCapabilities = &lsproto.DocumentSymbolClientCapabilities{
HierarchicalDocumentSymbolSupport: ptrTrue,
}
defaultFoldingRangeCapabilities = &lsproto.FoldingRangeClientCapabilities{
RangeLimit: ptrTo[uint32](5000),
// LineFoldingOnly: ptrTrue,
FoldingRangeKind: &lsproto.ClientFoldingRangeKindOptions{
ValueSet: &[]lsproto.FoldingRangeKind{
lsproto.FoldingRangeKindComment,
lsproto.FoldingRangeKindImports,
lsproto.FoldingRangeKindRegion,
},
},
FoldingRange: &lsproto.ClientFoldingRangeOptions{
CollapsedText: ptrTrue, // Unused by our testing, but set to exercise the code.
},
}
)

func getCapabilitiesWithDefaults(capabilities *lsproto.ClientCapabilities) *lsproto.ClientCapabilities {
Expand Down Expand Up @@ -554,6 +568,9 @@ func getCapabilitiesWithDefaults(capabilities *lsproto.ClientCapabilities) *lspr
if capabilitiesWithDefaults.TextDocument.DocumentSymbol == nil {
capabilitiesWithDefaults.TextDocument.DocumentSymbol = defaultDocumentSymbolCapabilities
}
if capabilitiesWithDefaults.TextDocument.FoldingRange == nil {
capabilitiesWithDefaults.TextDocument.FoldingRange = defaultFoldingRangeCapabilities
}
return &capabilitiesWithDefaults
}

Expand Down
Loading