Skip to content

fix(typespec-vscode): fix e2e create-project test failing on peer dep conflicts #10306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheeguerin merged 2 commits into from
Apr 8, 2026
+4 −11
Merged

fix(typespec-vscode): fix e2e create-project test failing on peer dep conflicts #10306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dde139
fix(typespec-vscode): fix e2e test to not require install artifacts
Copilot Apr 8, 2026
a9f827f
fix typo: rename 'exected' parameter to 'expected'
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/typespec-vscode/test/extension/common/common-steps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ export async function preContrastResult(

/**
* Results comparison
* @param exected List of expected files
* @param expected List of expected files that must be present in the directory
* @param dir The directory to be compared needs to be converted into an absolute path using path.resolve
*/
export async function expectFilesInDir(exected: string[], dir: string) {
export async function expectFilesInDir(expected: string[], dir: string) {
const results = await readdir(dir);
expect(results).toEqual(exected);
expect(results).toEqual(expect.arrayContaining(expected));
}

/**
Expand Down
9 changes: 1 addition & 8 deletions packages/typespec-vscode/test/extension/create-typespec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,7 @@ const CreateTypespecProjectFolderPath = path.resolve(tempDir, "CreateTypespecPro
const createCase = "CreateTypespecProject";
const templateName = "Generic Rest API";
const templateNameDescription = "Create a project representing a generic REST API service.";
const expectedResults = [
".gitignore",
"main.tsp",
"node_modules",
"package-lock.json",
"package.json",
"tspconfig.yaml",
];
const expectedResults = [".gitignore", "main.tsp", "package.json", "tspconfig.yaml"];

const CreateCasesConfigList: CreateConfigType[] = [
{
Expand Down
Loading