[compiler] Enum-driven visibility#4825
Merged
witemple-msft merged 37 commits intomicrosoft:mainfrom Nov 7, 2024
Merged
Conversation
witemple-msft
requested review from
allenjzhang,
bterlson,
markcowl and
timotheeguerin
as code owners
Collaborator
|
All changed packages have been documented.
|
…nto witemple-msft/visibility-enum
Contributor
|
Is there an uptake PR into typespec-azure? |
Collaborator
|
You can try these changes here
|
Member
Author
|
tsv passing: Azure/azure-rest-api-specs#31469 |
Member
Author
|
typespec-azure passing: Azure/typespec-azure#1829 |
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Nov 8, 2024
This PR is for validation of the uptake of microsoft/typespec#4825 It masks some no-deprecated lint errors that result from the deprecation of `getVisibility` --------- Co-authored-by: Will Temple <will@wtemple.net>
This was referenced Nov 14, 2024
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Dec 5, 2024
This PR is for validation of the uptake of microsoft/typespec#4825 It masks some no-deprecated lint errors that result from the deprecation of `getVisibility` --------- Co-authored-by: Will Temple <will@wtemple.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the design described in the Enum-Driven Visibility rework discussions.
There is still some work to be done:
The design documents are located at the following gist: https://gist.github.com/witemple-msft/f122c1fce83e72d102290b5678930ac5