[python3][python2] Use MKDIR_P to create directories to avoid race conditions #22902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ras0219-msft
changed the title
Contributor
|
LGTM! |
Contributor
|
For python3, we already applied #21734. Maybe it should be reverted if it wasn't sufficient. |
JackBoosY
approved these changes
Feb 3, 2022
JackBoosY
added
category:port-bug
…icrosoft#21734)" This reverts commit a515872. # Conflicts: # ports/python3/vcpkg.json # versions/baseline.json # versions/p-/python3.json
BillyONeal
approved these changes
Feb 4, 2022
Member
|
Thanks for the fix! |
ekilmer
added a commit
to ekilmer/vcpkg
that referenced
this pull request
Feb 5, 2022
* master: (221 commits) [vcpkg-tool] update to 2022-02-03 (microsoft#22924) [opencv4] Disable building cpufeatures since it conflict with libwebp (microsoft#22844) [rhasheq] New port (microsoft#22905) [sfml] Add arm64 patch to allow SFML to compile on apple silicon (microsoft#22937) [popsift] Fix missing Thrust include, already merged upstream. (microsoft#22929) [python3][python2] Use MKDIR_P to create directories to avoid race conditions (microsoft#22902) Added libe57format port (microsoft#22909) update polyhook2 (microsoft#22906) [botan] Fix debug info (microsoft#22911) [opentelemetry-cpp] update version to v1.2.0 (microsoft#22925) [docs] document VCPKG_INSTALLED_DIR variable (microsoft#22695) [c89stringutils] New port (microsoft#22904) [randomstr] New port (microsoft#22921) [docs] Add Authoring-script-ports.md (microsoft#22396) [vcpkg_fail_port_install] Deprecate function (microsoft#21489) [vcpkg-cmake-config] add missing TOOLS_PATH (microsoft#22863) Ace Build Windows - Missing files in include package (microsoft#22880) [opendnp3] Disable FetchContent in favor of predownloading (microsoft#22894) libraqm update to 0.9.0 (microsoft#22907) [google-cloud-cpp] update to latest release (v1.36.0) (microsoft#22897) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed intermittent failures for python2 and python3 on osx with the error log
Looking at the implementation of
altbininstall, it is using$(INSTALL)to create these folders. Apprently, the/usr/bin/installprogram on osx does not internally pass-ptomkdirunder normal circumstances. However, autotools already has provided for this by finding an appropriate mkdir that's safe:This program is stored as
MKDIR_P, so I've added a string replacement step that changes over every mkdir-via-install to use$(MKDIR_P)instead. I originally wanted to use a patch, but there are around 10 uses scattered through the file so it would be a reasonably large patchfile (~100 lines).There is potentially a concern about the produced directories not having customized permissions, however I don't think that should be an issue in the case of vcpkg.