Skip to content

[rhasheq] New port #22905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
strega-nil-ms merged 8 commits into from
Feb 4, 2022
Merged

[rhasheq] New port #22905

strega-nil-ms merged 8 commits into from
Feb 4, 2022

Conversation

@SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Feb 2, 2022

Describe the pull request

Simple header-only librhash wrapper for verifying hashes from a file to a given const char *.

https://github.com/offscale/rhasheq

  • What does your PR fix?

rhash/RHash#194

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Depends on #22904

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 3, 2022
@BillyONeal
Copy link
Member

BillyONeal commented Feb 4, 2022

  • Please merge with master in order to get the c89stringutils port from your other PR so that it isn't duplicated here.
  • Please fix the build failures:
[1/3] /usr/bin/cc  -I/mnt/vcpkg-ci/buildtrees/rhasheq/x64-linux-dbg/rhasheq_tests/src -I/mnt/vcpkg-ci/buildtrees/rhasheq/x64-linux-dbg/rhasheq_tests/test_downloads -I/mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq -I/mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq/C89STRINGUTILS_INCLUDE_DIRS-NOTFOUND -isystem /mnt/vcpkg-ci/installed/x64-linux/include -fPIC -g -Wall -Wextra -Wshadow -Wformat=2 -Wunused -pedantic -std=gnu90 -MD -MT rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o -MF rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o.d -o rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o -c /mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq_tests/test_rhasheq/test.c
FAILED: rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o 
/usr/bin/cc  -I/mnt/vcpkg-ci/buildtrees/rhasheq/x64-linux-dbg/rhasheq_tests/src -I/mnt/vcpkg-ci/buildtrees/rhasheq/x64-linux-dbg/rhasheq_tests/test_downloads -I/mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq -I/mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq/C89STRINGUTILS_INCLUDE_DIRS-NOTFOUND -isystem /mnt/vcpkg-ci/installed/x64-linux/include -fPIC -g -Wall -Wextra -Wshadow -Wformat=2 -Wunused -pedantic -std=gnu90 -MD -MT rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o -MF rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o.d -o rhasheq_tests/test_rhasheq/CMakeFiles/test_rhasheq.dir/test.c.o -c /mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq_tests/test_rhasheq/test.c
In file included from /mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq_tests/test_rhasheq/test_rhasheq.h:4,
                 from /mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq_tests/test_rhasheq/test.c:7:
/mnt/vcpkg-ci/buildtrees/rhasheq/src/344c2a7363-fb02ccb12c.clean/rhasheq/rhasheq.h:20:10: fatal error: c89stringutils_string_extras.h: No such file or directory
   20 | #include <c89stringutils_string_extras.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

@strega-nil
Copy link
Contributor

strega-nil commented Feb 4, 2022

Thanks!

@strega-nil-ms strega-nil-ms merged commit 24f83d5 into microsoft:master Feb 4, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 5, 2022
@ekilmer
Merge branch 'master' into more-lief
8d7ebb2 
* master: (221 commits)
  [vcpkg-tool] update to 2022-02-03 (microsoft#22924)
  [opencv4] Disable building cpufeatures since it conflict with libwebp (microsoft#22844)
  [rhasheq] New port (microsoft#22905)
  [sfml] Add arm64 patch to allow SFML to compile on apple silicon (microsoft#22937)
  [popsift] Fix missing Thrust include, already merged upstream. (microsoft#22929)
  [python3][python2] Use MKDIR_P to create directories to avoid race conditions (microsoft#22902)
  Added libe57format port (microsoft#22909)
  update polyhook2 (microsoft#22906)
  [botan] Fix debug info (microsoft#22911)
  [opentelemetry-cpp] update version to v1.2.0 (microsoft#22925)
  [docs] document VCPKG_INSTALLED_DIR variable (microsoft#22695)
  [c89stringutils] New port (microsoft#22904)
  [randomstr] New port (microsoft#22921)
  [docs] Add Authoring-script-ports.md (microsoft#22396)
  [vcpkg_fail_port_install] Deprecate function (microsoft#21489)
  [vcpkg-cmake-config] add missing TOOLS_PATH (microsoft#22863)
  Ace Build Windows - Missing files in include package (microsoft#22880)
  [opendnp3] Disable FetchContent in favor of predownloading (microsoft#22894)
  libraqm update to 0.9.0 (microsoft#22907)
  [google-cloud-cpp] update to latest release (v1.36.0) (microsoft#22897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Adela0814 Adela0814

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SamuelMarks @BillyONeal @strega-nil @JackBoosY @strega-nil-ms @Adela0814