-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[vcpkg baseline][omplapp] Skip due to conflict with ompl #40151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg baseline][omplapp] Skip due to conflict with ompl #40151
Conversation
|
How do you ensure that the vendored ompl runtime libs created and used during the build of |
Thanks for your comment, the build-in Given that |
|
According to https://ompl.kavrakilab.org/download.html "The OMPL.app repository contains the OMPL repository as a submodule.". I checked, and omplapp's submodule for 1.6 references the same SHA as for ompl 1.6, and they were released on the same day. Does it make sense to remove |
add_subdirectory(ompl/doc)
add_subdirectory(ompl/src)
add_subdirectory(ompl/py-bindings)
add_subdirectory(ompl/tests)
add_subdirectory(ompl/demos)
add_subdirectory(ompl/scripts)And there are many different parts between the two files omplapp/CMakeLists.txt and ompl/CMakeLists.txt. Splitting the two projects seems need a lot of changes, I will discuss with upstream. |
Can you post the link to the discussion? |
|
@talregev Sorry for late, I submitted the issue now. |
|
@WangWeiLin-MV Don't worry about it. |
|
Close before upstream update. |
Fix https://dev.azure.com/vcpkg/public/_build/results?buildId=105429&view=logs&j=ac0731cb-f2f9-5764-2e0a-a6fa8ebb4a08
Since
omplappcoupled withompl, andomplhas been fixed and enabled CI test in #40080:omplappasskipChecklist
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.Test
The port installation tests pass with the following triplets: