[ompl,omplapp] Overhaul #43987
Merged
[ompl,omplapp] Overhaul #43987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangWeiLin-MV
added
the
category:port-update
WangWeiLin-MV
approved these changes
Feb 25, 2025
Contributor
There was a problem hiding this comment.
Could it be changed to CMAKE_DISABLE_FIND_PACKAGE_ ?
Contributor
Author
There was a problem hiding this comment.
No. ompl and omplapp rely on extra functions and macros being added by its own FindPython.cmake. This is solved by the noop module vendored into the port.
WangWeiLin-MV
added
the
category:port-bug
WangWeiLin-MV
approved these changes
Feb 25, 2025
Contributor
WangWeiLin-MV
left a comment
WangWeiLin-MV
left a comment
There was a problem hiding this comment.
The port installation tests pass with the following triplets:
- x64-linux
- x64-windows
WangWeiLin-MV
added
the
info:needs-maintainer-attention
adamtajti
pushed a commit
to adamtajti/vcpkg
that referenced
this pull request
Feb 27, 2025
adamtajti
pushed a commit
to adamtajti/vcpkg
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reliably control/disable dependencies.
Update omplapp to 1.6.0, and reuse instead of duplicate ompl. We are aware of the embedding at least since #40151.
Extend ompl CMake config with omplapp targets.
Cleanup.
It is really just at at the edge of "to remove
omplappand addompl[app]which locks the inner ompl sources at the same value", as suggested by @BillyONeal in #40151 (comment).