Native wayland support with newest electron

[toger5]

Native wayland support would be great to run vs code without XWayland as described in #77752.

Recently electron merged the chrome version with the ozone backend needed:
electron/electron#26022

This would allow for:

• Kinetic scrolling (maybe this is more elegantly implemented on the elctron side)
• Better touch support (touch scrolling)
• better dpi scaling

[deepak1556]

Thanks for opening the issue, agree with the benefits. The electron PR only got the basic compilation bits, there will be follow-up PRs to make it feature complete. VSCode will consume those binaries once they are available.

Upstream issue: electron/electron#10915

[kriive]

Ozone has now landed in stable chrome (87) and in electron 11.0.1! I tried to compile vscode in electron-11.x.x branch, targeting electron 11.0.1. It compiles fine, but if I launch code as follows: code-oss --verbose --log=TRACE --enable-features=UseOzonePlatform --ozone-platform=wayland it shows a window for half a second and then crashes without any log. If I leave out the ozone cli commands vscode starts ok, without crashing.

EDIT: if I run it through gdb it now segfaults. [Thread 1 "code-oss" received signal SIGSEGV, Segmentation fault.
0x00005555576c1630 in ?? ()]

[tyalie]

There's also a Wayland debug flag (WAYLAND_DEBUG=1). Maybe you can find more there.

[kriive]

Thanks, this is the output given: WAYLAND_DEBUG=1 gdb --args ./code-oss --enable-features=UseOzonePlatform --ozone-platform=wayland
https://pastebin.com/raw/ALk3JGz6

This is what happens

[vially]

As far as I'm aware the official builds for Electron 11 do not have Wayland support. The initial Wayland support (electron/electron#26022) will only land in Electron 12.

So unless you're using an unofficial Electron build which has backported the Wayland fixes (e.g.: electron-ozone from the AUR) I think it's expected for the build to crash.

[deepak1556]

@vially is correct, the initial experimental support landed only in electron 12, once I merge #110759 to master , the exploration builds of vscode will start using electron 12. Can check again on the crash after that change.

[12101111]

electron-11 compile from my Gentoo Linux overlay works without any issue ( And works with musl libc! )

[kriive]

Uhm, @12101111 are you launching vscode with --enable-features=UseOzonePlatform --ozone-platform=wayland?