# ## Pound Hash signs should not be marked as comments in SQL #8174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL uses # as comments along with the standard SQL '--' at the beginning. However, # is not standard SQL and therefore when using SQL Server/Oracle, etc. things marked with # are still shown as comment in the code even if they aren't comments. SQL Server specifically uses # ## to denote temporary tables. Therefore, until someone figures out how to write a mysql exception to the syntax highlighting, I would suggest we suppress this code.
|
By analyzing the blame information on this pull request, we identified @egamma to be a potential reviewer |
|
Hi @gontadu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
gontadu
changed the title
Contributor
|
@gontadu Please file this request to https://github.com/textmate/sql.tmbundle first. |
Contributor
Author
|
It is done upstream, but seeing the activity on that bundle.. it might take a while. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL uses # as comments along with the standard SQL '--' at the beginning. However, # is not standard SQL and therefore when using SQL Server/Oracle, etc. things marked with # are still shown as comment in the code even if they aren't comments. SQL Server specifically uses # ## to denote temporary tables.
Therefore, until someone figures out how to write a mysql exception to the syntax highlighting, I would suggest we suppress this code.