Conversation
This was referenced Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type traits used internally by the
windowscrate for modeling various abstractions and reasoning about how certain types behave have long been somewhat cumbersome due to the inability to express mutually exclusive type traits in Rust. Well, I stumbled upon an approach that can do just that. We can now distinguish between reference and value types, and other potential categories, and provide unique behavior and associated types in a single place. This will take a few iterations to polish, but this is a good start and simplifies a lot of that plumbing considerably.This work was motivated by my desire to work on #91 but that requires reasoning more clearly about types and so you will also see some much-needed improvements to the way the
implementmacro generated generic constraints.