Conversation
This was referenced Mar 2, 2023
Merged
This was referenced Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update builds on #2343 and dramatically simplifies input parameter bindings, somethings that's always been rather complicated as we've attempted to model convertibility in Rust. Rather than depend on thousands of
FromandTryFromimplementations, types now implement the marker traits calledCanIntoandCanTryIntothat do nothing but indicate to thewindowscrate that such types are convertible. The various Windows APIs can then rely on these traits to transform input arguments in the most efficient way possible, either casting directly to a parent interface - in a COM hierarchy - or callingQueryInterfacewhen a conversion is expected - in a WinRT hierarchy.The end result is a simpler abstraction with far less code. Specifically, it avoids generating around 6,000
TryFromimplementations and many thousands ofFromimplementations. That amounts to a lot of functions that the Rust compiler doesn't have to parse, saving on build time.For most applications, this change won't be noticeable as parameter bindings should just work as before. There are however two main changes that you might run into.
The
Interfacetrait has been renamed toComInterfaceto more accurately reflect what it represents. So, if you're relying on thecastmethod for explicit conversions then you might have touse ComInterfacerather thanuse Interface.If you previously relied on the
TryFromimplementations for explicit WinRT conversions, simply use thecastmethod instead. The oldertry_fromimplementations simply calledcastunder the hood. This just saves having to generate thousands of wrapper functions and should improve your build time. In addition, theFromimplementations for COM hierarchies are no longer generated. You shouldn't need them often, but if you don't want to callcast(which injects a call toQueryInterface) then you can use thecan_intoorcan_clone_intohelpers for optimal performance.