Set User-Agent for HTTP requests#612
Merged
AmelBawa-msft merged 1 commit intomicrosoft:mainfrom Jul 10, 2025
Merged
Conversation
AmelBawa-msft
approved these changes
Jul 10, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Pipeline failing for the same reason: #597 (comment) |
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR sets the User-Agent request header in the standard format (
WinGetCreate/<Cli-Version>)For reference, the winget-cli user-agent is
winget-cli WindowsPackageManager/<CLI-Version> DesktopAppInstaller/<AppInstaller-Version>. The comment in the source code mentions thatwinget-cliis there for historical reasons.https://github.com/microsoft/winget-cli/blob/8115f41de486ef4c4a4cc064be57016ee5cbe44e/src/AppInstallerCommonCore/Runtime.cpp#L533-L543
Validation
Manually verified that
wingetcreate new https://www.atlassian.com/software/jira/downloads/binary/atlassian-jira-software-9.12.25-x64.exeworks after settings the User-AgentMicrosoft Reviewers: Open in CodeFlow