Skip to content

Ignore usernames when checking spelling#89510

Merged
denelon merged 1 commit intomicrosoft:masterfrom
me-and:spelling
Dec 7, 2022
Merged

Ignore usernames when checking spelling#89510
denelon merged 1 commit intomicrosoft:masterfrom
me-and:spelling

Conversation

@me-and
Copy link
Copy Markdown
Contributor

@me-and me-and commented Nov 23, 2022

Moderators.md lists a number of usernames that are being caught by the spell checker, but clearly are meant to be there. Don't fail the spellcheck because of them.

This doesn't seem to affect the builds in microsoft/winget-pkgs, but I'm definitely getting failures reported for the builds in my fork, which I need to push to in order to be able to submit PRs here.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Obviously a bunch of the above checks aren't relevant for this PR!

Microsoft Reviewers: Open in CodeFlow

Moderators.md lists a number of usernames that are being caught by the
spell checker, but clearly are meant to be there.  Don't fail the
spellcheck because of them.
@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@ghost
Copy link
Copy Markdown

ghost commented Nov 23, 2022

me-and,

Changes to one or more files in your PR require authorization to modify. This PR has been assigned to our on call staff to evaluate.

Template: msftbot/requiresApproval/MSFT

@ghost ghost assigned stephengillie and yao-msft Nov 23, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 24, 2022
@jsoref jsoref mentioned this pull request Nov 30, 2022
6 tasks
@denelon denelon merged commit 597d9c0 into microsoft:master Dec 7, 2022
@me-and me-and deleted the spelling branch December 10, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants