Skip to content

Upgrade to Check Spelling v0.0.21#90103

Merged
denelon merged 1 commit intomicrosoft:masterfrom
jsoref:check-spelling-v0.0.21
Dec 7, 2022
Merged

Upgrade to Check Spelling v0.0.21#90103
denelon merged 1 commit intomicrosoft:masterfrom
jsoref:check-spelling-v0.0.21

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Nov 30, 2022

Note: <path> is the name of the directory containing the manifest you're submitting.


This PR upgrades check-spelling to v0.0.21
This adds a couple of features, including GitHub job summaries (which can be much longer than comments, but are out-of-line).

Probably the most appealing interesting new feature for users of this repository is that you should be able to update expect.txt easily from Windows.

As always, if you have problems, please let me know.


Before reenabling the workflow

I believe you will want to delete these branches:

This branch should be rebased:

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@ghost
Copy link
Copy Markdown

ghost commented Nov 30, 2022

jsoref,

Changes to one or more files in your PR require authorization to modify. This PR has been assigned to our on call staff to evaluate.

Template: msftbot/requiresApproval/MSFT

@ghost ghost assigned stephengillie and ryfu-msft Nov 30, 2022
Comment thread .github/workflows/spellCheck.yaml
Comment thread .github/actions/spelling/patterns.txt
Comment thread .github/actions/spelling/patterns.txt
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 30, 2022
@denelon
Copy link
Copy Markdown
Collaborator

denelon commented Dec 7, 2022

@jsoref it looks like there are a few unresolved conversations. Do you want to resolve them and have me merge, or are you looking for additional feedback?

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Dec 7, 2022

@denelon oh, those are merely notes explaining how things work. I've resolved them to avoid confusing anyone

@denelon denelon merged commit a8dd01f into microsoft:master Dec 7, 2022
@jsoref jsoref deleted the check-spelling-v0.0.21 branch December 7, 2022 22:10
@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Dec 7, 2022

@stephengillie: can you please delete and rebase the branches noted in the description above?

@Lut9310
Copy link
Copy Markdown

Lut9310 commented Jan 3, 2025

Note: <path> is the name of the directory containing the manifest you're submitting.


This PR upgrades check-spelling to v0.0.21
This adds a couple of features, including GitHub job summaries (which can be much longer than comments, but are out-of-line).

Probably the most appealing interesting new feature for users of this repository is that you should be able to update expect.txt easily from Windows.

As always, if you have problems, please let me know.


Before reenabling the workflow

I believe you will want to delete these branches:

This branch should be rebased:

Microsoft Reviewers: Open in CodeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants