Getting crash in Android OS 7

[atulgpt]

While in process of uploading file to OneDrive, we are getting crash on device OS 7. We couldn't verify this crash on Android OS level below 7 as we get the crash in CalenderSerializer before this flow kicks in.

Crash logs are as follow:
--------- beginning of crash 10-15 10:32:12.228 13689 13689 E AndroidRuntime: FATAL EXCEPTION: main 10-15 10:32:12.228 13689 13689 E AndroidRuntime: Process: com.adobe.reader, PID: 13689 10-15 10:32:12.228 13689 13689 E AndroidRuntime: java.lang.NoSuchMethodError: No interface method getTypeName()Ljava/lang/String; in class Ljava/lang/reflect/Type; or its super classes (declaration of 'java.lang.reflect.Type' appears in /system/framework/core-oj.jar) 10-15 10:32:12.228 13689 13689 E AndroidRuntime: at com.microsoft.graph.serializer.CollectionPageSerializer.deserialize(CollectionPageSerializer.java:115) 10-15 10:32:12.228 13689 13689 E AndroidRuntime: at com.microsoft.graph.serializer.GsonFactory$12.deserialize(GsonFactory.java:229) 10-15 10:32:12.228 13689 13689 E AndroidRuntime: at com.microsoft.graph.serializer.GsonFactory$12.deserialize(GsonFactory.java:224) 10-15 10:32:12.228 13689 13689 E AndroidRuntime: at

Expected behavior

It shouldn't crash and handle newer apis with fallback mechanish or apis that is supported in older OS version

Devices tested where issue is observed:

Asus Tab, Samsung J7, Samsung Tab A, Galaxy S6

Cause

After some analysis, I found that crash is originating from CollectionPageSerializer which is being registered into Gson type adapter and which in function deserialize calls the method Type#getTypeName() which is a default method added after Java 1.8

Also can we make gson variable in DefaultSerializer public so that while configuring the graph client we can replace these problematic TypeAdapters with the custom solution. Like in case of when XXX is not supported in simpleDateFormat then same can be replaced with joda-time as we already have that dependency. Similarly in this case as well usage of getTypeName() can be replace with getName() or getCannonicalName() as to avoid crash

[baywet]

Hi @atulgpt
Thanks for reaching out.
For reference, the character issue you mentioned #530
The use of the method

msgraph-sdk-java/src/main/java/com/microsoft/graph/serializer/CollectionPageSerializer.java

Line 115 in cd580a4

final String collectionPageClassCanonicalName = typeOfT.getTypeName();

The documentation that states this method was introduced with Java 1.8 https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Type.html and default methods are a Java 8 concept https://www.javatpoint.com/java-default-methods.
Android 7 is API level 24 https://developer.android.com/studio/releases/platforms#7.0 which supports default methods https://stackoverflow.com/a/46873490/3808675.
The catch is that getTypeName was apparently added in API level 28 https://developer.android.com/reference/java/lang/reflect/Type#getTypeName()

What's your minSdkVersion, your targetSdkVersion and have you enabled desugaring?

[atulgpt]

Hi @baywet I have just ran the sample app with coreLibraryDesugaringEnabled turned to true and still getting the crash java.lang.NoSuchMethodError: No virtual method getTypeName()Ljava/lang/String; in class Ljava/lang/Class; or its super classes (declaration of 'java.lang.Class' appears in /system/framework/core-libart.jar) while accessing the line AttachmentCollectionPage::class.java.typeName

Desugaring only changes the client code and don't affect the OS framework code. And if the method is missing in OS framework then it will definitely crash. And in case of newer apis like stream or Future or JSR310 coreLibraryDesugaringEnabled adds similar methods that delegates to already present apis on the OS or creates similar classes but I think right now typeOfT.getTypeName() is not supported in coreLibraryDesugaringEnabled

In my sample app. minSdkVersion 21, targetSdkVersion 29 and compileSdkVersion 29
Lib version used for coreLibraryDesugaringEnabled: 'com.android.tools:desugar_jdk_libs:1.0.10'