Skip to content

feature/android api baseline #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baywet merged 23 commits into from
Nov 18, 2020
Merged

feature/android api baseline #558

baywet merged 23 commits into from
Nov 18, 2020

Conversation

@baywet
Copy link
Member

@baywet baywet commented Nov 12, 2020 •
edited
Loading

fixes #546
fixes #542

  • upgrades gradle wrapper
  • fixes a bug where locale wasn't definied for string formats potentially leading to formatting errors
  • adds gradle wrapper for android profile
  • adds gitignore for android test project
  • adds android project structure
  • adds nonnull and nullable annotations
  • fixes use of type.getTypeName API not available in level 21 through 25
  • adds failsafe for X character not available in level 21 through 23
  • removes synthetic accessors

Note:

template used for library

TODO:

  • mutualize the dependencies through a common gradle file + apply from: path to file
  • add github actions pipelines to run this on PRs
  • fix remaining issues
  • decide which API level to adopt (probably 21 or 23)
  • update documentation
  • reflect changes on core

@baywet baywet marked this pull request as draft November 12, 2020 20:47
@baywet baywet mentioned this pull request Nov 12, 2020
Closed
@baywet baywet self-assigned this Nov 12, 2020
@baywet baywet added this to the 3.0.0 milestone Nov 12, 2020
@baywet baywet linked an issue Nov 12, 2020 that may be closed by this pull request
Clearly define and document minimum support API level #546
Closed
@baywet baywet mentioned this pull request Nov 16, 2020
Merged
@baywet baywet mentioned this pull request Nov 16, 2020
Merged
2 tasks
@baywet baywet requested review from MIchaelMainer and removed request for MIchaelMainer November 17, 2020 18:26
@baywet baywet marked this pull request as ready for review November 17, 2020 18:26
@baywet baywet linked an issue Nov 17, 2020 that may be closed by this pull request
Getting crash in Android OS 7 #542
Closed
@github-actions

This comment has been minimized.

Sign in to view
zengin
zengin approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a sampled review, LGTM.

@baywet baywet merged commit c51e78f into feature/v3 Nov 18, 2020
@baywet baywet deleted the feature/android-api-baseline branch November 18, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@nikithauc nikithauc Awaiting requested review from nikithauc

1 more reviewer

@zengin zengin zengin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

conflicting

Projects

None yet

Milestone

3.0.0-preview

Development

Successfully merging this pull request may close these issues.

Clearly define and document minimum support API level Getting crash in Android OS 7

4 participants

@baywet @zengin @marlyd