Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 9, 2021

This pull request was automatically created by the GitHub Action, create pull request.

The commit hash is 4c354b7.

Important Check for unexpected deletions or changes in this PR.

@baywet baywet force-pushed the v1.0/pipelinebuild/43180 branch from 165ee03 to 0d9768b Compare March 9, 2021 12:51
baywet
baywet previously approved these changes Mar 9, 2021
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zengin @MIchaelMainer as this is a single property addition and only comments besides that, I suggest we ditch that release to reduce consumers update pressure. Thoughts?

@baywet baywet added this to the 2.10.0 milestone Mar 9, 2021
@MIchaelMainer
Copy link
Collaborator

I have mixed thoughts. Big picture, this change is inconsequential. But, someone could be waiting on the displayname property; a code comment might help someone. There is also the value in the fresh perception of a regular release cadence. I lean towards release. @mairissi for input.

@zengin
Copy link
Contributor

zengin commented Mar 9, 2021

I think regular release cadence is one of the metrics we are interested in to measure the success of generation work we are doing.

We should probably think about aligning it with metadata releases instead of weekly cadence as AGS sometimes skips publishing the metadata. I am OK with skipping documentation changes but I can imagine a world where everything is automated upon a metadata release to have the corresponding SDK release right after.

@baywet
Copy link
Member

baywet commented Mar 9, 2021

@MIchaelMainer @zengin alright, I'm not strongly for or against releasing. 2 out of 3 in favor, I'm happy with this democratic decision :)
I'll merge it in once #693 is merged.

@baywet baywet merged commit 428a13a into dev Mar 9, 2021
@baywet baywet deleted the v1.0/pipelinebuild/43180 branch March 9, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants