bugfix/default content type and boolean deserialization #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication/octet-stream content type
baywet
requested review from
MIchaelMainer,
ddyett,
nikithauc and
zengin
as code owners
…' of https://github.com/microsoftgraph/msgraph-sdk-java into bugfix/default-content-type-and-boolean-deserialization
zengin
approved these changes
Mar 9, 2021
Contributor
zengin
left a comment
zengin
left a comment
There was a problem hiding this comment.
Looks good, but I feel that this logic should belong to the core library as the beta service library will also be subject to the same bug. What do you think?
| final JsonElement element = json.getAsJsonObject().get("@odata.null"); | ||
| if(element != null && element.isJsonPrimitive()) { | ||
| return getPrimitiveValue(element, type); | ||
| } else { |
Contributor
There was a problem hiding this comment.
nit: else block can be removed
baywet
deleted the
bugfix/default-content-type-and-boolean-deserialization
branch
Member
Author
|
@zengin thanks for the review. Yeah all of that has been moved to the core library with the v3 work. I just authored the reflective PR for v3 in core (see the item linked right above this comment). |
Contributor
|
@baywet thanks for the TL;DR. it was a long thread, I must have missed it while skimming through :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #687