Update dependencies and remove dotnet 7 support#65
Update dependencies and remove dotnet 7 support#65follesoe wants to merge 5 commits intomicrospaze:mainfrom
Conversation
Remove net7.0 since it is obsolete and went out of support on May 14th, 2024.
The ImageServiceBaseTests was failing due to MemoryCache either not being set on the PlatformImageLoaderTask, or by the ImageService returning a new instance of the mock cache for every access to the property.
|
@microspaze Some feedback/merge would be greatly appreciated 😫 |
|
If you have abandoned it I wouldn't mind being assigned contributor to the library. It's just so annoying with tons of forks and different similar NuGet package names etc. So better if we can use this repo and the existing NuGet package going forward. |
That would be appropriate, this library could use contributors as it's the most popular FFImageLoading successor for .NET MAUI with over 500k downloads on NuGet. Still, the best option might be to migrate away from FFImageLoading, as was recommended more than 2 years ago. |
|
@microspaze can this be taken care of? |
|
Never mind, I see that Skia has been upgraded here: b1bc8a8 So we can probably close this PR. |
3 participants
This PR fixes the failing tests in
ImageServiceBaseTests. It also updates external dependencies to the latest versions and removes support for dotnet 7.Dotnet 7 was out of support in May 2024, so it can safely be removed as a target.
The goal of the PR is to keep
FFImageLoading.Mauiup-to-date, and prepare it for an update of theSvg.Skiadependency.The library was pinned at an old version
1.0.0.10ofSvg.Skia, which again prevented updates to SkiaSharp in projects using this library. I have opened pull requests against theSvg.Skiaupdating it to SkiaSharp v3. Once/if hat PR gets merged, I will update FFImageLoading.Maui to support the newSvg.Skiapackage, which would also allow us to update to SkiaSharp v3 which is the end-goal.