Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated AsciiDoc conditional guards to use version-specific Changes
Sequence Diagram(s)(omitted — changes are documentation/editorial and do not introduce multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
@Pkylas007, peer review completed. I've left some suggestions, see my notes. Overall I'd be careful in replacing all passive voice with active as many sentences start sounding anthropomorphic and otherwise odd. Plus I'd rework abstracts to make them fit bot DITA and Style Guides criteria (no self-referential text, consistency in wording, etc.).
@vashirova Thank you! The CQA recommendation for non-permitted passive voice is to re-write the sentences in active voice.
@Pkylas007 passive voice is our Style Guides requirements and thus must be fixed. I agree that it doesn't make sense to change all instances and we must evaluate all instances one by one. However if we are replacing passive voice, we should consider our style guides to not introduce other violations. |
|
RedHat style guide rules do not state that release notes headings must not have imperative verbs. |
Actually the SSG is clear on that one. Imperative is to be used for procedural and task-based content and RNs do not fit here. See https://redhat-documentation.github.io/supplementary-style-guide/#titles-and-headings. Plus, for RNs specifically SSG says 'Follow the specifics for the release note type" https://redhat-documentation.github.io/supplementary-style-guide/#headings-for-release-notes. Imperative doesn't indicate what type of change it is, instead it calls to an action when we are just describing the change. |
The SSG has a separate section for Release Notes headings and that section doesn't prohibit an imperative. It makes sense too: not to be too restrictive about how exactly the RN headings are written :) |
While the RN section in SSG doesn't comment on imperative, the other linked section makes it clear. "Specify" in RNs makes the heading sound like an instruction for a procedure rather than a summary of a fixed bug. For fixed issues, the heading should be a declarative statement summarizing the resolution or the state of the product after the update. With imperative wording I cannot understand what's been changed. We should not be using imperative for any RNs headings. |
Specify includes the fact that the user "can" specify: otherwise, the RN fixed bug section will not ask them to do so. Besides, the description makes it very clear what exactly has changed to enable the user to perform something. No? But for the sake of getting on with the task, I'll close this discussion 😄 |
|
I have made all the required changes and attached the compressed result of the following test results in MTA-6806:
|
|
@anarnold97 please confirm if MTA-6231 in release notes must be moved to new features and enhancements section based on Dylan's clarification. |
@Pkylas007 - i did clarify on Friday, see HERE |
ad64237 to
3348610
Compare
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
JIRA
Version
Preview
Summary by CodeRabbit
Documentation
Chores