Skip to content

[April CQA] MTA CLI formatting, markup, and the remaining CQA fixes#358

Merged
mpershina merged 5 commits intomainfrom
CLI-quality-CQA
Apr 17, 2026
Merged

[April CQA] MTA CLI formatting, markup, and the remaining CQA fixes#358
mpershina merged 5 commits intomainfrom
CLI-quality-CQA

Conversation

@mpershina
Copy link
Copy Markdown
Collaborator

@mpershina mpershina commented Apr 16, 2026

Tracked under:

Preview: https://mpershina.github.io/Previews/MTA/CLI-fixes.html

Summary by CodeRabbit

Documentation

  • Refined code block formatting and command highlighting across CLI documentation for improved clarity
  • Clarified Developer Preview notice messaging with updated terminology and added links to support scope resources
  • Enhanced documentation structure and example rendering for better readability

@mpershina mpershina self-assigned this Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

This PR updates MTA documentation across 13 files with consistency improvements for Developer Preview terminology, enhanced AsciiDoc formatting for code examples, updated cross-references, and refined text styling and wording throughout CLI-related procedures and references.

Changes

Cohort / File(s) Summary
Developer Preview Terminology Updates
assemblies/cli-guide/assembly_generating-assets.adoc, docs/topics/mta-cli/proc_analyzing-multiple-apps-with-mta-cli.adoc, docs/topics/mta-cli/ref_supported-migration-paths.adoc
Updated "Developer Preview feature/features" to "Developer Preview software," added non-breaking spaces in "Red Hat," refined testing phrasing ("limited testing" instead of "testing is limited"), and added links to the Developer Preview Support Scope page.
AsciiDoc Code Block Formatting
docs/topics/mta-cli/proc_analyze-unsupported-provider.adoc, docs/topics/mta-cli/proc_assets-generation-example.adoc, docs/topics/mta-cli/proc_concealing-sensitive-information.adoc, docs/topics/mta-cli/proc_performing-a-live-discovery.adoc, docs/topics/mta-cli/proc_generating-deployment-manifest.adoc
Replaced generic placeholder blocks with explicit [source,yaml] code blocks, added proper ---- delimiters, and inserted additional empty separator blocks for improved example rendering.
Link and Cross-Reference Updates
assemblies/cli-guide/assembly_reference-material.adoc, docs/topics/mta-cli/proc_reviewing-analysis-issues-and-incidents.adoc
Updated "Rules Development Guide" hyperlink target and location, removed inline cross-references in favor of a dedicated "Additional resources" section with structured cross-references.
Text Formatting and Wording Refinements
docs/topics/mta-cli/proc_analyzing-app-with-profile.adoc, docs/topics/mta-cli/ref_modify-application-profile.adoc, docs/topics/mta-cli/proc_running-the-containerless-mta-cli.adoc
Wrapped CLI commands in emphasis, reformatted placeholder variables with underscores, updated capitalization for consistency ("Specifies" vs. "specifies"), removed version-specific language, and adjusted prerequisite/link structure.
Minor Structural Adjustments
docs/topics/mta-cli/proc_generate_deployment_assets_values_file.adoc
Added blank line separator after parameter list for improved readability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • anarnold97
  • Pkylas007

Poem

🐰 Through docs the rabbit hops with care,
Formatting blocks with spacing rare,
Developer Preview words now bright,
Code samples polished, AsciiDoc just right,
Links aligned, the prose takes flight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title '[April CQA] MTA CLI formatting, markup, and the remaining CQA fixes' accurately describes the changeset, which contains documentation formatting updates, markup adjustments, and CQA corrections across multiple MTA CLI documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch CLI-quality-CQA

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/topics/mta-cli/proc_analyzing-app-with-profile.adoc`:
- Line 48: The placeholder in the AsciiDoc command example uses hyphens but
should use underscores per the repo style; update the command string in the
mta-cli example (the line containing "mta-cli config sync --url
https://github.com/_<my-app-repository>_ --application-path _<path_to_my_app>_
--insecure") to replace `<my-app-repository>` with `<my_app_repository>` (keep
the surrounding underscores/italics like the other placeholders) so it matches
the repository's underscore convention for placeholders.

In `@docs/topics/mta-cli/proc_generate_deployment_assets_values_file.adoc`:
- Around line 71-72: Remove the standalone continuation marker '+' that appears
immediately after the `where` definition list; replace that '+' line with a
plain blank line so the sentence "The variable priority hierarchy for generating
deployment manifests is as follows:" is not treated as a continuation of the
last `where` item and renders as a separate paragraph.

In `@docs/topics/mta-cli/proc_generating-deployment-manifest.adoc`:
- Around line 48-51: Remove the duplicated `cat Dockerfile` snippet from the
"Verify the ConfigMap" section and keep the Dockerfile verification command only
in the "Verify the Dockerfile" section; search for the headings "Verify the
ConfigMap" and "Verify the Dockerfile" and delete the `[subs="+quotes"] ---- $
*cat Dockerfile* ----` block found under the ConfigMap heading (the block at the
adjacent 53-63 area) so the Dockerfile is verified exclusively in the Dockerfile
step.

In `@docs/topics/mta-cli/proc_running-the-containerless-mta-cli.adoc`:
- Line 13: Update the phrasing that currently reads "is a default mode" to use
the definite article — change it to "is the default mode" in the sentence
describing Containerless CLI; locate the sentence containing the exact fragment
"Containerless CLI is a default mode" and replace that fragment so the line
reads "Containerless CLI is the default mode."

In `@docs/topics/mta-cli/ref_modify-application-profile.adoc`:
- Line 72: The description for the `labels` field has a subject-verb agreement
error: change the verb "filters" to the plural form "filter" so the sentence
reads "Specifies the labels that filter rules that are applied and excluded in
the analysis." Update the string containing `labels`:: in the docs (the line
with `labels`:: Specifies...) to use "filter" instead of "filters".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31dc50f8-33c9-4b4e-9570-24d1af5bd8ed

📥 Commits

Reviewing files that changed from the base of the PR and between 97b249f and 998ceba.

📒 Files selected for processing (14)
  • assemblies/cli-guide/assembly_generating-assets.adoc
  • assemblies/cli-guide/assembly_reference-material.adoc
  • docs/topics/mta-cli/proc_analyze-unsupported-provider.adoc
  • docs/topics/mta-cli/proc_analyzing-app-with-profile.adoc
  • docs/topics/mta-cli/proc_analyzing-multiple-apps-with-mta-cli.adoc
  • docs/topics/mta-cli/proc_assets-generation-example.adoc
  • docs/topics/mta-cli/proc_concealing-sensitive-information.adoc
  • docs/topics/mta-cli/proc_generate_deployment_assets_values_file.adoc
  • docs/topics/mta-cli/proc_generating-deployment-manifest.adoc
  • docs/topics/mta-cli/proc_performing-a-live-discovery.adoc
  • docs/topics/mta-cli/proc_reviewing-analysis-issues-and-incidents.adoc
  • docs/topics/mta-cli/proc_running-the-containerless-mta-cli.adoc
  • docs/topics/mta-cli/ref_modify-application-profile.adoc
  • docs/topics/mta-cli/ref_supported-migration-paths.adoc

Comment thread docs/topics/mta-cli/proc_analyzing-app-with-profile.adoc Outdated
Comment thread docs/topics/mta-cli/proc_generating-deployment-manifest.adoc Outdated
Comment thread docs/topics/mta-cli/proc_running-the-containerless-mta-cli.adoc Outdated
Comment thread docs/topics/mta-cli/ref_modify-application-profile.adoc
Comment thread docs/topics/mta-cli/proc_generating-deployment-manifest.adoc Outdated
Comment thread docs/topics/mta-cli/proc_analyzing-app-with-profile.adoc Outdated
@mpershina mpershina requested a review from anarnold97 April 16, 2026 15:13
Copy link
Copy Markdown
Collaborator

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpershina mpershina merged commit 28c1418 into main Apr 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants