Skip to content

Fix: Volumes paginated#3

Merged
nicholi merged 2 commits intodevelopfrom
fix/volumes_paginated
Sep 2, 2024
Merged

Fix: Volumes paginated#3
nicholi merged 2 commits intodevelopfrom
fix/volumes_paginated

Conversation

@nicholi
Copy link

@nicholi nicholi commented Sep 2, 2024

Noticed the Volumes list calls (/v2/volumes) returns the the paginated links section as relative URLs and not absolute.

  "links": {
    "pages": {
      "next": "/v2/volumes?page=2",
      "last": "/v2/volumes?page=10"
    }
  },

Is this a DO API bug? Or has it always been this way? We haven't used volumes up till this point, primarily Droplets. Which have always returned an absolute URL in their links section.

Slight fixes to generating next page call, will now safely allow both.

@nicholi nicholi merged commit 771b5ea into develop Sep 2, 2024
@nicholi nicholi mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant