Skip to content

Fix: Volumes paginated#9

Merged
nicholi merged 11 commits intomainfrom
fix/volumes_paginated
May 9, 2025
Merged

Fix: Volumes paginated#9
nicholi merged 11 commits intomainfrom
fix/volumes_paginated

Conversation

@nicholi
Copy link

@nicholi nicholi commented May 9, 2025

Noticed the Volumes list calls (/v2/volumes) returns the the paginated links section as relative URLs and not absolute.

  "links": {
    "pages": {
      "next": "/v2/volumes?page=2",
      "last": "/v2/volumes?page=10"
    }
  },

Is this a DO API bug? Or has it always been this way? We haven't used volumes up till this point, primarily Droplets. Which have always returned an absolute URL in their links section.

Slight fixes to generating next page call, will now safely allow both.

Duplicate against our new main #3

@nicholi nicholi merged commit a9ae931 into main May 9, 2025
@nicholi nicholi deleted the fix/volumes_paginated branch May 9, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants