fix epochs.plot_image for EMG data #11322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
force-pushed
the
plot_image_emg
branch
from
dfc85a6 to
71478b4
Compare
agramfort
commented
Nov 13, 2022
| ch_names = np.array(one_evoked.ch_names)[picks].tolist() | ||
| ch_types = [t for t in _get_channel_types(info, picks=picks, unique=True) | ||
| if t in _DATA_CH_TYPES_SPLIT + ('misc',)] # miscICA | ||
| if t in _DATA_CH_TYPES_SPLIT + ('misc', 'emg')] # miscICA |
Member
Author
There was a problem hiding this comment.
I am also wondering if we should simply make EMG channels data channels...
Member
|
What sets EMG channels apart from resp, ecg, and eog? Why would you want to treat EMG more like a data channel than any of the others? |
Member
Author
|
No strong feeling but I just ask the question...
… Message ID: ***@***.***>
|
Member
|
I double checked our docs 📝 https://mne.tools/dev/glossary.html#term-data-channels
We can add |
Member
|
Thanks @agramfort ! |
larsoner
added a commit
to ruuskas/mne-python
that referenced
this pull request
Nov 17, 2022
* upstream/main: fix epochs.plot_image for EMG data (mne-tools#11322) fix fontawesome icon display (mne-tools#11328) [DOC, MRG] fix/improve documentation of n_jobs for apply_function (mne-tools#11325) [MAINT, MRG] fix is_mesa (mne-tools#11313) BUG: Fix bug with parallel progress bars (mne-tools#11311) BUG: Fix bug with report replacement (mne-tools#11318) MAINT: Fix docs (mne-tools#11317) Fix typo in changelog (mne-tools#11315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11312