fix fontawesome icon display #11328
Merged
fix fontawesome icon display #11328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
drammock
commented
Nov 16, 2022
| font_class = ('fa-brands' if icon in brand_icons else 'fa-solid',) | ||
| icons[icon] = font_class + ('fa-fw',) if icon in fixed_width_icons else () | ||
| icon_class[icon] = ('fa-brands',) if icon in brand_icons else ('fa-solid',) | ||
| icon_class[icon] += ('fa-fw',) if icon in fixed_width_icons else () |
Member
Author
There was a problem hiding this comment.
this line was the crucial change. there was a scope problem for the if/else, such that non-fixed-width icons were ending up with no classes.
drammock
commented
Nov 16, 2022
Comment on lines
+1015
to
+1023
| 'book', 'code-branch', 'newspaper', 'circle-question', 'quote-left', | ||
| # contrib guide: | ||
| 'bug', 'comment', 'hand-sparkles', 'magic', 'pencil-alt', 'remove-format', | ||
| 'universal-access', 'discourse', 'python', | ||
| 'bug-slash', 'comment', 'computer-mouse', 'hand-sparkles', 'pencil', | ||
| 'text-slash', 'universal-access', 'wand-magic-sparkles', | ||
| 'discourse', 'python', | ||
| ) | ||
| other_icons = ( | ||
| 'hand-paper', 'question', 'rocket', 'server', 'code', 'desktop', | ||
| 'terminal', 'cloud-download-alt', 'wrench', 'hourglass' | ||
| 'terminal', 'cloud-arrow-down', 'wrench', 'hourglass-half' |
Member
Author
There was a problem hiding this comment.
name changes here reflect changes between FontAwesome 5 and 6. This should hopefully make things more future-proof, as I think support for the old names goes away with FA7.
larsoner
pushed a commit
that referenced
this pull request
Nov 16, 2022
Member
|
Merged and backported, thanks @drammock |
larsoner
added
backported
and removed
backport-candidate
larsoner
added a commit
to ruuskas/mne-python
that referenced
this pull request
Nov 17, 2022
* upstream/main: fix epochs.plot_image for EMG data (mne-tools#11322) fix fontawesome icon display (mne-tools#11328) [DOC, MRG] fix/improve documentation of n_jobs for apply_function (mne-tools#11325) [MAINT, MRG] fix is_mesa (mne-tools#11313) BUG: Fix bug with parallel progress bars (mne-tools#11311) BUG: Fix bug with report replacement (mne-tools#11318) MAINT: Fix docs (mne-tools#11317) Fix typo in changelog (mne-tools#11315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11320