Add mne.preprocessing.unify_bad_channels #12014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
drammock
reviewed
Sep 25, 2023
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
drammock
requested changes
Sep 27, 2023
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
looks good so far, see comments below.
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
anaradanovic
requested review from
agramfort,
cbrnr and
larsoner
as code owners
drammock
reviewed
Sep 27, 2023
drammock
reviewed
Sep 27, 2023
drammock
reviewed
Sep 27, 2023
Co-authored-by: Daniel McCloy <dan@mccloy.info>
larsoner
reviewed
Sep 28, 2023
Add test functions to test new unify function
drammock
approved these changes
Sep 28, 2023
Member
|
nice work @anaradanovic and @nordme! In it goes |
larsoner
changed the title
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: nordme <nordme@uw.edu> Co-authored-by: nordme <38704848+nordme@users.noreply.github.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #11481