FIX: skip empty lines in read_raw_eyelink #12172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes a problem with reading an Eyelink file that was raised on the Discussion forum: https://mne.discourse.group/t/issue-with-read-raw-eyelink/7787
The problematic file provided by the researcher had a line that only contained a newline character, which broke the parser.
This branch checks for and skips empty lines, fixing the problem.
I did a quick performance check to see how much longer file reading takes with the additional checks:
on main:
on this branch: