Tweak logo for dark mode #12176

cbrnr · 2023-11-06T17:01:26Z

Fixes #11791. I made the text a bit lighter (60% gray), which makes it easier to read in dark mode. It should be still quite readable in light mode as well.

Old (current) light:

Old (current) dark:

New light:

New dark:

drammock

I like the choice of color, but [nitpick] the diff is quite large, because of editing via inkscape. Could you instead tweak the script that generates the logo? I think it's this line:

mne-python/logo/generate_mne_logos.py

Line 129 in 8ea98e2

tag_patch = PathPatch(tag_clip, facecolor="k", edgecolor="none", zorder=10)

hoechenberger · 2023-11-06T17:40:58Z

Looks very nice!!!

hoechenberger · 2023-11-06T17:41:56Z

Actually. Shouldn't we get rid of the tagline. Or change it: Brain analysis ... or something like that?

cbrnr · 2023-11-07T05:56:01Z

I cannot generate the updated logo:

findfont: Generic family 'sans-serif' not found because none of the following families were found: Primetime
/Users/clemens/Projects/mne-python/logo/generate_mne_logos.py:111: MatplotlibDeprecationWarning: The collections attribute was deprecated in Matplotlib 3.8 and will be removed two minor releases later.
  for coll in cs.collections:
findfont: Generic family 'sans-serif' not found because none of the following families were found: Cooper Hewitt
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
File ~/Projects/mne-python/logo/generate_mne_logos.py:181
    178 patch.remove()
    180 # modify to make an icon
--> 181 ax.patches.pop(-1)  # no tag line for our icon
    182 patch = Ellipse(xy, r, r, clip_on=False, zorder=-1, fc="k")
    183 ax.add_patch(patch)

AttributeError: 'ArtistList' object has no attribute 'pop'

cbrnr · 2023-11-07T08:10:34Z

And yes, I did install the font.

hoechenberger · 2023-11-07T08:13:54Z

Maybe you need to refresh the MPL font cache?

cbrnr · 2023-11-07T08:15:25Z

Thanks, that was it!

Now I saw that the logo also needs the "Primetime" font, which is only free for personal use. I'm not sure that our logo qualifies for personal use.

Edit: I'm now using "Cooper Hewitt" everywhere.

cbrnr · 2023-11-07T08:28:43Z

Replacing the Primetime font is not a good idea, the PNGs look terrible...

larsoner · 2023-11-07T16:17:26Z

The image diffs look like they're headed in a good direction! A couple of things I noticed though:

The main logo tagline gets harder to read when shrunk (at least on GH diff view):
mne/icons/mne_default_icon.png and mne/icons/mne_splash.png which are a bit off:

Let me know if you want help. My first/naive thought is that maybe we don't need center_fudge anymore at least for the icon and splash, but the white outline is also off so there is probably more to it than that.

Now I saw that the logo also needs the "Primetime" font, which is only free for personal use... I'm now using "Cooper Hewitt" everywhere.

Makes sense to switch if that is indeed the case. @drammock okay with the switch away from PrimeTime? I think it looks fine/comparable to me but IIRC you chose the fonts originally

cbrnr · 2023-11-07T16:40:24Z

@larsoner please feel free to take over! Regarding your first point, I think you need to look at it with white background, because it get's hard to read because of the checkered background IMO.

Also, the SVG diffs are still massive even though they were generated with the script (but apparently, a lot has changed in how MPL renders SVGs?). But I guess that's OK.

drammock · 2023-11-07T17:09:23Z

Now I saw that the logo also needs the "Primetime" font, which is only free for personal use.

from the designer's website:

With a free for Personal use version, you can't use PRIMETIME © for a commercial purpose.

MNE is not commercial software, so as I said long ago as long as we're not fundraising, selling the stickers, or start charging for MNE I think we're in the clear.

@drammock okay with the switch away from PrimeTime? I think it looks fine/comparable to me but IIRC you chose the fonts originally

I chose CooperHewitt but I think @agramfort chose Primetime (and I recall being discouraged from changing it when I was scripting the logo generation because "Alex likes Primetime"). Anyway I don't think we need to change it, see above.

hoechenberger · 2023-11-07T17:29:57Z

Let's not touch Alex's Primetime then 🎉🍹

larsoner · 2023-11-07T18:18:06Z

Okay I think I'm happy now. @drammock @cbrnr feel free to look -- GitHub has a nice image diff nowadays! Changes:

Tweaked tagline the weight upward slightly -- I've noticed especially on HiDPI screens (my mac) that the Light font is difficult to read.
Added a little sanity check that matplotlib probably/hopefully finds the correct font. On my system I had several weights and it always used Thin even though I had thin/light/book/medium installed and I think it was supposed to pick Light. So I had to rm the other variants then fc-cache update and rerun. Now I have it using Book.
To offset this, I moved from black to "0.2" and from white to "0.8" which I think helps reduce the prominence close to what it was before without sacrificing readability on HiDPI displays.
Added mne_logo_gray.svg that lives in doc/_static. Once it deploys tonight we can change our README.rst to use mne.tools/dev/_static/mne_logo_gray.svg.

larsoner · 2023-11-07T18:29:41Z

Okay I'll actually stop pushing commits now!

logo/generate_mne_logos.py

drammock · 2023-11-07T19:31:38Z

@larsoner OK by me if you merge when happy

larsoner · 2023-11-07T20:43:12Z

doc/sphinxext/gen_commands.py

        from sphinx.util.display import status_iterator
    except Exception:
        from sphinx.util import status_iterator
-    root = Path(__file__).parent.parent.parent.absolute()


Even on this branch:

$ git grep "\.parent\.parent" | wc -l 70

but they are now at least all isolated to tests files, I made the others more compact in this PR

cbrnr · 2023-11-07T21:02:07Z

Wait, why am I seeing this on my phone in dark mode (README.rst on main):

larsoner · 2023-11-07T21:19:52Z

No idea, I can't replicate on my mobile or on macOS in inspection mode as an iPhone, or in Safari

hoechenberger · 2023-11-07T21:28:10Z

You mean that gray bar underneath the tagline?

hoechenberger · 2023-11-07T21:53:02Z

Looks like this for me now in the browser and GH app:

cbrnr · 2023-11-08T06:04:33Z

You mean that gray bar underneath the tagline?

No, I meant the white (gray?) text, which is 100% readable (on main). But apparently, this is a dark mode feature on my Android phone, because I cannot replicate on my Mac. Still, pretty neat!

hoechenberger · 2023-11-08T06:59:39Z

I cannot read the tagline in dark mode 🥲 (see my screenshots above)

cbrnr · 2023-11-08T07:03:18Z

Yes, I think it's something my phone does.

hoechenberger · 2023-11-08T07:27:44Z

Yeah but … wasn't that something this PR aimed to address too? 😅

cbrnr · 2023-11-08T07:49:20Z

Yes, but as @larsoner mentioned here, we merged this prematurely. I'm not entirely sure what the plan is, but he created a third logo variant mne_logo_gray.svg, which I think we need to include in README.rst. Previously, I modified mne_logo.svg directly, which is the logo currently included in README.rst.

cbrnr · 2023-11-08T07:51:27Z

#12184

hoechenberger · 2023-11-08T09:43:25Z

Ah okay! I missed that!

* upstream/main: BUG: Fix bug with spectrum warning (mne-tools#12186) Add argument splash to disable splash-screen from Qt-browser (mne-tools#12185) BUG: Fix bug with logging and n_jobs>1 (mne-tools#12154) Use gray logo (works in light and dark modes) (mne-tools#12184) Tweak logo for dark mode (mne-tools#12176) ENH: Improve Covariance.__repr__ (mne-tools#12181) ENH: Enable sensor-specific OPM coregistration in mne coreg (mne-tools#11405) Tweak README.rst (mne-tools#12166) [pre-commit.ci] pre-commit autoupdate (mne-tools#12177) MAINT: Add branch coverage (mne-tools#12174) OpenSSF (mne-tools#12175) fix docstring in 60_sleep.py (mne-tools#12171) FIX: skip empty lines in read_raw_eyelink (mne-tools#12172) FIX: Fix bug with coreg scalars (mne-tools#12164) Changed casting rule in np.clip to allow reading of raw GDF files (mne-tools#12168) [DOC] Add documentation for setting montage order (mne-tools#12160) Fix inferring fiducials from EEGLAB (mne-tools#12165)

…o-pyproject.toml * upstream/main: MAINT: Fix CIs (mne-tools#12188) BUG: Fix bug with default alpha and axes (mne-tools#12187) BUG: Fix bug with spectrum warning (mne-tools#12186) Add argument splash to disable splash-screen from Qt-browser (mne-tools#12185) BUG: Fix bug with logging and n_jobs>1 (mne-tools#12154) Use gray logo (works in light and dark modes) (mne-tools#12184) Tweak logo for dark mode (mne-tools#12176) ENH: Improve Covariance.__repr__ (mne-tools#12181) ENH: Enable sensor-specific OPM coregistration in mne coreg (mne-tools#11405) Tweak README.rst (mne-tools#12166)

hoechenberger · 2023-11-09T10:12:53Z

Only slightly related but I thought it was funny:

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>

Tweak logo for dark mode

fa13632

cbrnr requested review from agramfort, dengemann, drammock and larsoner as code owners November 6, 2023 17:01

drammock approved these changes Nov 6, 2023

View reviewed changes

Set text color to 60% gray

dd484c6

cbrnr marked this pull request as draft November 7, 2023 05:56

Fix icon generation script

94a1680

cbrnr added 2 commits November 7, 2023 09:30

Sort imports

b9b32fc

Fix docstring

2da3526

larsoner added 2 commits November 7, 2023 12:19

WIP: Closer [ci skip]

e57b6d4

WIP: Closer [ci skip]

c7139e9

larsoner added 5 commits November 7, 2023 13:05

FIX: Weight [ci skip]

a8f7b99

FIX: In between? [ci skip]

2e81465

FIX: Tiny bit darker [ci skip]

d7d6885

FIX: In between [ci skip]

2e2157d

FIX: In between [ci skip]

cf949f6

larsoner added 2 commits November 7, 2023 13:26

FIX: Level

a36d733

FIX: Level

aa8c667

larsoner added this to the 1.6 milestone Nov 7, 2023

drammock approved these changes Nov 7, 2023

View reviewed changes

logo/generate_mne_logos.py Outdated Show resolved Hide resolved

logo/generate_mne_logos.py Outdated Show resolved Hide resolved

larsoner added 2 commits November 7, 2023 15:39

FIX: parents

b564fb2

FIX: parents

ef6a5e4

larsoner reviewed Nov 7, 2023

View reviewed changes

larsoner added 2 commits November 7, 2023 15:43

FIX: One

7ef536b

FIX: Ruff

7b8d2a4

larsoner enabled auto-merge (squash) November 7, 2023 20:45

larsoner mentioned this pull request Nov 7, 2023

MAINT: Replace Path.parent.parent with Path.parents #12183

Closed

larsoner merged commit ffbce01 into mne-tools:main Nov 7, 2023

cbrnr deleted the tweak-logo branch November 8, 2023 06:04

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024

Tweak logo for dark mode (mne-tools#12176)

94a08ce

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>

Uh oh!

Tweak logo for dark mode #12176

Tweak logo for dark mode #12176

Uh oh!

Conversation

cbrnr commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

drammock left a comment

Choose a reason for hiding this comment

Uh oh!

hoechenberger commented Nov 6, 2023

Uh oh!

hoechenberger commented Nov 6, 2023

Uh oh!

cbrnr commented Nov 7, 2023

Uh oh!

cbrnr commented Nov 7, 2023

Uh oh!

hoechenberger commented Nov 7, 2023

Uh oh!

cbrnr commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbrnr commented Nov 7, 2023

Uh oh!

larsoner commented Nov 7, 2023

Uh oh!

cbrnr commented Nov 7, 2023

Uh oh!

drammock commented Nov 7, 2023

Uh oh!

hoechenberger commented Nov 7, 2023

Uh oh!

larsoner commented Nov 7, 2023

Uh oh!

larsoner commented Nov 7, 2023

Uh oh!

Uh oh!

Uh oh!

drammock commented Nov 7, 2023

Uh oh!

larsoner Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

cbrnr commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

larsoner commented Nov 7, 2023

Uh oh!

hoechenberger commented Nov 7, 2023

Uh oh!

hoechenberger commented Nov 7, 2023

Uh oh!

cbrnr commented Nov 8, 2023

Uh oh!

hoechenberger commented Nov 8, 2023

Uh oh!

cbrnr commented Nov 8, 2023

Uh oh!

hoechenberger commented Nov 8, 2023

Uh oh!

cbrnr commented Nov 8, 2023

Uh oh!

cbrnr commented Nov 8, 2023

Uh oh!

hoechenberger commented Nov 8, 2023

Uh oh!

hoechenberger commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cbrnr commented Nov 6, 2023 •

edited

Loading

cbrnr commented Nov 7, 2023 •

edited

Loading

cbrnr commented Nov 7, 2023 •

edited

Loading

hoechenberger commented Nov 9, 2023 •

edited

Loading