Fix incorrect type hint in Neuralynx I/O module #12236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect type hint sneaked in via mne-tools#11969, causing confusion to static type checkers. Since we don't use type hints in MNE yet (except for some very rare exceptions), I simply removed the faulty one instead of fixing it.
Member
Author
|
@larsoner I also think it's unusual that |
Member
|
Yes |
Member
Author
|
Can you take over please? I'm a bit busy with other stuff :) |
Member
Author
|
@larsoner I rearranged the signature but didn't add a changelog entry yet |
hoechenberger
force-pushed
the
neuralynx
branch
from
9b2acf2 to
b588492
Compare
* upstream/main: Add some omitted dependencies to "full" and "doc" variants (mne-tools#12235) Fix pyproject.toml setuptools configuration (mne-tools#12240) FIX: Allow eyetrack channels to be used with plot_compare_evoked (mne-tools#12190)
larsoner
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
Member
Author
|
Thanks for cleaning things up, @larsoner! |
larsoner
pushed a commit
that referenced
this pull request
Nov 28, 2023
larsoner
added
backported
and removed
backport-candidate
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect type hint sneaked in via #11969, causing confusion to static type checkers.
Since we don't use type hints in MNE yet (except for some very rare exceptions), I simply removed the faulty one instead of fixing it.
cc @KristijanArmeni
FYI the correct hint for our supported versions of Python would be
Optional[List[str]]orUnion[None, List[str]]