Skip to content

fix icon link colors #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 1 commit into from
Dec 18, 2023
Merged

fix icon link colors #12301

larsoner merged 1 commit into from
Dec 18, 2023

Conversation

@drammock
Copy link
Member

@drammock drammock commented Dec 17, 2023

closes #12285

@drammock
Copy link
Member Author

drammock commented Dec 18, 2023

results:

Screenshot 2023-12-18 at 10-07-25 Computation times — MNE 1 7 0 dev45 ga27da3a6b documentation

Screenshot 2023-12-18 at 10-05-30 Computation times — MNE 1 7 0 dev45 ga27da3a6b documentation

@drammock drammock enabled auto-merge (squash) December 18, 2023 16:11
@drammock
Copy link
Member Author

drammock commented Dec 18, 2023

windows pip-pre is failing on the print config step. Same failure today (after restarting) and last Friday. The error msg is not very informative:

"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\1f58f2bd-d074-4b82-af8b-1ca9aa287737.cmd""
##[error]Cmd.exe exited with code '-1073741819'.

anyone with a windows machine able to reproduce this with mne sys_info -pd?

@larsoner
Copy link
Member

larsoner commented Dec 18, 2023

All PRs are failing that way. I should be able to look tomorrow

@larsoner larsoner disabled auto-merge December 18, 2023 19:37
@larsoner larsoner merged commit 0a0cad8 into mne-tools:main Dec 18, 2023
@larsoner
Copy link
Member

larsoner commented Dec 18, 2023

Thanks @drammock !

@drammock drammock deleted the fix-web-icon-colors branch December 18, 2023 20:01
larsoner added a commit to larsoner/mne-python that referenced this pull request Dec 20, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into changelog
30bbf57 
* upstream/main:
  BUG: handle temporal discontinuities in Neuralynx `.ncs` files (mne-tools#12279)
  MAINT: Work around bad SciPy nightly wheels (mne-tools#12317)
  fix 404 link on devel landing page (mne-tools#12316)
  Switch from `epoch_data` to `data` for TFR array functions (mne-tools#12308)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12307)
  fix icon link colors (mne-tools#12301)
  Bump actions/download-artifact from 3 to 4 (mne-tools#12304)
  Bump github/codeql-action from 2 to 3 (mne-tools#12303)
  Bump actions/upload-artifact from 3 to 4 (mne-tools#12302)
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@drammock @snwnde
fix icon link colors (mne-tools#12301)
13de5dc
@drammock drammock mentioned this pull request Aug 5, 2024
Merged
@drammock drammock mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Twitter logo in docs should not be colored

3 participants

@drammock @larsoner @agramfort